mirror/jak-project
1
0
Fork 0
mirror of https://github.com/open-goal/jak-project synced 2026-07-08 14:36:52 -04:00
Code Issues Packages Projects Releases Wiki Activity

[jak3] Fix audio language setting (#4093)

Browse Source 
Rename `Language` to `Audio Language` in the menu, and connect it to
`audio-language` instead of `language`.

After this change, we have:
<img width="559" height="322" alt="image"
src="https://github.com/user-attachments/assets/d928a91b-6184-4bde-b147-aa08f22b02d2"
/>


where 

- Subtitle Language controls `subtitle-language` on both PC settings and
the normal setting control (unchanged)
- Audio Language controls `audio-language` on setting-control
- Text Language controls `text-language` on PC settings and `language`
on setting control. The game looks at `(-> *setting-control*
user-default language)` to determine text scaling sometimes, so I think
it's good for this to set both.
This commit is contained in:
water111
2025-12-08 17:53:26 -05:00
committed by GitHub
parent 4814bb2e41
commit 0ea38cb2da
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
goal_src/jak3/pc/progress/progress-static-pc.gc
+4 -3
View File
@@ -492,7 +492,7 @@ This gives us more freedom to write code how we want.
(defmacro game-options-pc-sound-language ()
`(new 'static 'menu-generic-carousel-option
:name (text-id progress-language)
:name (text-id progress-audio-language)
:items (new 'static 'boxed-array :type text-id
(text-id progress-language-english)
(text-id progress-language-french)
@@ -507,9 +507,9 @@ This gives us more freedom to write code how we want.
(text-id progress-language-dutch)
(text-id progress-language-english-uk)
)
:get-item-index-fn (lambda () (-> *setting-control* user-default language))
:get-item-index-fn (lambda () (-> *setting-control* user-default audio-language))
:on-confirm (lambda ((index int) (the-progress progress))
(set! (-> *setting-control* user-default language) (the-as language-enum index)))))
(set! (-> *setting-control* user-default audio-language) (the-as language-enum index)))))
(defmacro game-options-pc-text-language ()
`(new 'static 'menu-generic-carousel-option
@@ -544,6 +544,7 @@ This gives us more freedom to write code how we want.
)
:get-item-index-fn (lambda () (-> *pc-settings* text-language))
:on-confirm (lambda ((index int) (the-progress progress))
(set! (-> *setting-control* user-default language) (the-as language-enum index))
(set! (-> *pc-settings* text-language) (the-as pc-language index))
;; NOTE - this doesn't actually work (naughty dog tried it too in their progress code)
(load-level-text-files (the-as int (-> *pc-settings* text-language)))