mirror/jak-project
1
0
Fork 0
mirror of https://github.com/open-goal/jak-project synced 2026-06-03 18:36:52 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix build failure at llvm-rc on windows due to codepage error on zydis (#3088)

Browse Source 
This fix is for the following error when building with llvm on windows

```
[build] llvm-rc: Error in VERSIONINFO statement (ID 1): 
[proc] The command: "C:\Program Files\CMake\bin\cmake.exe" --build C:/.../git/jak-project-test/out/build/Release --parallel 8 exited with code: 1
[build] Non-ASCII 8-bit codepoint (´┐¢) can't be interpreted in the current codepage
[build] ninja: build stopped: subcommand failed.
```

It's caused by llvm-rc not handling non 8-bit characters.
The same issue is discussed in the curl project here
https://github.com/curl/curl/issues/7765

This commit copies the fix from curl, replacing '©' with '(C)'.
This commit is contained in:
jabermony
2023-10-15 15:38:14 +01:00
committed by GitHub
parent e6b73f1058
commit 95dca764fc
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
third-party/zydis/resources/VersionInfo.rc
Generated Vendored
+1 -1
View File
@@ -47,7 +47,7 @@ BEGIN
VALUE "FileDescription", "Zyan Disassembler Library"
VALUE "FileVersion", "4.0.0.0"
VALUE "InternalName", "Zydis"
VALUE "LegalCopyright", "Copyright © 2014-2021 by zyantific.com"
VALUE "LegalCopyright", "Copyright (C) 2014-2021 by zyantific.com"
VALUE "OriginalFilename", "Zydis.dll"
VALUE "ProductName", "Zyan Disassembler Library"
VALUE "ProductVersion", "4.0.0.0"