* 99% match
* Rewrote _execute to increase accuracy. Only issue in .text is a label not loading correctly. I have no idea how to fix this.
* Equivalent. Weak func ordering.
* 7% text
* 28% text
* 41% text
* 65% text
* Rewrote _execute to increase accuracy. Only issue in .text is a label not loading correctly. I have no idea how to fix this.
* Equivalent. Weak func ordering.
* 82% text
* Equivalent. A lot of work is needed to name variables and clean up functions. Weak function ordering is wrong.
* Cleaned some functions, named several variables, and began documenting dialog tree.
* Naming a couple more variables
* 21% text
* change out getMySubstanceP for getMyIntegerP inline
* 100% text
* Refactor to use JUT_ASSERT macro
* #181: d_a_tag_attention matching; TODO: implement chk_inside and dComIfGp_att_Look2RequestF
* #181: continue working on d_a_tag_attention, matching almost complete
* #181: revert naming class member (not certain enough)
* #181: preliminary changes to resolve#784 comments regarding usage of debug maps
* #181: commit suggestion by @WilliamArnett, fixing regalloc error
Co-authored-by: WilliamArnett <149556961+WilliamArnett@users.noreply.github.com>
* #181: fix missing curly bracket
* #181: resolve#784 comments with the kind help of @WilliamArnett;
move `daTagAttention::Act_c::chk_inside` to header file; split `plyrToObjVec` definition to match assembly;
remove temp variable, use values directly and swap operands;
implement `Look2RequestF` in `include/d/d_attention.h`;
remove non-matching use of temp variable `iVar1` and replace `current.pos` with uninitialized variable in `daTagAttention::Act_c::_execute`
* Update fork to match upstream
* some changes
* 73% text
* 100% Matching minus kaji_anm
* Delete debug/m2cdecomp
* revert unnecessary file changes
* remove d_a_npc_p2_cut.inc
* Match kaji_anm
* swap declaration order of l_msg and l_msgId
* Naming many fields
* Implement GetKajiID inline
* Enum and variable names
* Remove virtual genMessage function
* Implement @LagoLunatic 's suggested changes
* Revert array changes in d_camera.h (@LagoLunatic suggested change)
* Whitespace
* Rename dSnap enum
---------
Co-authored-by: Skelp <skelp@pm.me>
Co-authored-by: Skelp <59535863+Skelp@users.noreply.github.com>
* fopMsgM_msgDataProc_c::stringSet work
* Fix JPN
* More stringSet work
* work
* get rid of fake temps
* stringSet 99.99%
* fopMsgM_msgDataProc_c::stringLength 100%
* d_msg work
* fix pal
* fix message_paper, d_meter version diff fixes
* First version of d_scope, everything is matching on all version, probably missing a few inline on undocumented field that i did not manage to find
* Readd stuff previously deleted but badly tested
* Rename some fields and a few more inline
doesn't improve matching but i think it looks more genuine
* clean up syntax
* move d_scptyp enum and add forgotten inline
* build fix
* replace seStart call with proper enum
* 99% match
* Rewrote _execute to increase accuracy. Only issue in .text is a label not loading correctly. I have no idea how to fix this.
* Equivalent. Weak func ordering.
* 7% text
* 28% text
* 41% text
* 65% text
* Rewrote _execute to increase accuracy. Only issue in .text is a label not loading correctly. I have no idea how to fix this.
* Equivalent. Weak func ordering.
* 82% text
* Equivalent. A lot of work is needed to name variables and clean up functions. Weak function ordering is wrong.
* Cleaned some functions, named several variables, and began documenting dialog tree.
* Naming a couple more variables
* 21% text
* change out getMySubstanceP for getMyIntegerP inline
* 100% text
* Refactor to use JUT_ASSERT macro
* #181: d_a_tag_attention matching; TODO: implement chk_inside and dComIfGp_att_Look2RequestF
* #181: continue working on d_a_tag_attention, matching almost complete
* #181: revert naming class member (not certain enough)
* #181: preliminary changes to resolve#784 comments regarding usage of debug maps
* #181: commit suggestion by @WilliamArnett, fixing regalloc error
Co-authored-by: WilliamArnett <149556961+WilliamArnett@users.noreply.github.com>
* #181: fix missing curly bracket
* #181: resolve#784 comments with the kind help of @WilliamArnett;
move `daTagAttention::Act_c::chk_inside` to header file; split `plyrToObjVec` definition to match assembly;
remove temp variable, use values directly and swap operands;
implement `Look2RequestF` in `include/d/d_attention.h`;
remove non-matching use of temp variable `iVar1` and replace `current.pos` with uninitialized variable in `daTagAttention::Act_c::_execute`
* Update fork to match upstream
* some changes
* 12% text
* 21% text
* 26% text
* 43% text
* 51% text
* Revert unnecessary file changes
* Update d_a_tag_attention.cpp
* 55% text
* 52% text
* 52% text
* 56% text
* 68%
* 77% text
* 100% matching minus regswap
* 100% matching for retail
* Many more demo matches
* Fix broken match in _create()
* Demo Match
* Add some missing inlines
* Fix dComIfGp_setMesgCameraInfoActor
* More inline matching
* fix broken demo match
* Name some fields
* Utilize EventBit enum
* Name more fields, and add inline calls to d_a_npc_ls1
* Remove comments
* Implement @LagoLunatic suggested changes
* remove actor cast from dSnap_RegistFig calls
* Fix broken match in eInit_ATTENTION_
* Second round of @LagoLunatic 's suggested changes
---------
Co-authored-by: Skelp <skelp@pm.me>
Co-authored-by: Skelp <59535863+Skelp@users.noreply.github.com>
* d_a_npc_mt 100% for GZLE01
* implemented dPb_erasePicture and added some relevant inlines
* fixed existing references to mSelectPicture
* PR changes made
* d_a_kb Almost Matching
- Get most of the logic in
Still need to switch over from inheritance to composition, will fix at least 2/3 of the functions
* Switch Inheritance -> Composition
Causes regressions in way_check and target_set
* Use More Enums
Now uses res/loop mode/item number/sound/particle/collision attribute/event flag enums properly
* Fix d_a_npc_people
Used kb_class in a couple spots
* Another Inline
Found it in the debug map
* Joint Enums
- Add joint enums with note about normal/big pigs needing to have (at least partially) identical joint setups
* Assert for Joint Numbers
- Make sure the joint numbers match for the normal pig + big pig models
- Update/extend note accordingly
* d_a_lstair - 100% matching for GZLE01
* d_a_lstair - 100% matching for GZLE01 - restore comment deleted by mistake
* d_a_lstair - 100% matching for GZLE01 - fix return values of functions in the MethodTable; replace code with some inlines and macros; improve some casting locations; replace some magic numbers with enum usage; adjust res enum file according general update in the codebase
* d_a_lstair - 100% matching for GZLE01 - remove useless parameter
* d_a_lstair - 100% matching for GZLJ01, GZLE01 and GZLP01
WilliamArnett