Commit Graph

528 Commits

Author SHA1 Message Date
Zeclos 3755fbfd39 D_a_npc_photo (#759)
* bit too difficult for me for now, might go back later

* progress

* getmsg

* logic matching data isnt

* data section matches

* mathubcg 100%

* cleanup

* revert this change

* final cleanup and configure.py

* nevermind cleanup

* Equivalent onstead of matching

* removed padding

* cleanup code comments and a bit more

* Fix build

---------

Co-authored-by: LagoLunatic <LagoLunatic@users.noreply.github.com>
2025-05-25 17:01:01 -04:00
LagoLunatic 7cd75e8f7b Demo matches (#767) 2025-05-24 18:54:46 -04:00
Squidysquid1 5190f081c7 d_a_machine 100% (#754)
* d_a_machine 83%

* d_a_machine 87%

* d_a_machine matching functions

* 99% d_a_machine

* d_a_machine 100%

* Unmark as matching for demo

---------

Co-authored-by: LagoLunatic <LagoLunatic@users.noreply.github.com>
2025-05-24 14:15:28 -04:00
Mm2PL 6ff1da3741 d_a_jbo (#744)
* Do initial work on d_a_jbo

* Remove outdated comments

* Move co_sph_src to be a function static variable

* Mark as matching

* Rename mParamsLower to mParam

* Give names to mFramesUntilJump, mAnimRotation, mAnimationSpeed, mParticlePos

* Give jbo_class::mState an enum

* fixup! Give names to mFramesUntilJump, mAnimRotation, mAnimationSpeed, mParticlePos

* Give resource ids an enum

* Add documentation comment for actor

* MWCC shenanigans

* Rename variables to better match coding guidelines

* Apply suggestions from code review

- use J3DModel::setBaseScale() inline
- use existing resource id enum
- rename `i_actor` -> `i_this`, `that` -> `a_this`
- use defines for missed returned booleans
- replace `mDoAud_seStart` -> `fopAcM_seStart`

Co-Authored-By: LagoLunatic <LagoLunatic@users.noreply.github.com>

* Apply rest of inlines

i must have forgotten about them earlier

---------

Co-authored-by: LagoLunatic <LagoLunatic@users.noreply.github.com>
2025-05-22 20:28:56 -04:00
Ammar Askar 78d6f0384b Merge pull request #765 from ammaraskar/d_a_fire
Match and link d_a_fire
2025-05-22 17:59:39 -04:00
LagoLunatic d2f46f131a Demo: Add missing demo-only TU configs 2025-05-19 23:02:38 -04:00
LagoLunatic 99c78680de Fix version defines 2025-05-19 20:17:13 -04:00
LagoLunatic fd6cb6e4ca Fix weak function order of dBgS_MoveBgActor::Draw
fixes #217
fixes #239
fixes #389
fixes #418
fixes #428
fixes #147
2025-05-19 18:41:23 -04:00
Ammar Askar 661f53bc8a d_a_hys 100% equivalent with weak func order (#758)
* Start matching d_a_hys

* Add d_a_hys 100% except for weak func ordering

* Enable nosyminline

* Address PR comments
2025-05-19 14:49:44 -04:00
Azurpourpre 3f9a041528 D_a_kita matching (#751)
* ride_call_back progress

* daKita_Draw match

* kita_move progress

* ride_call_back match

* daKita_Execute will match

* daKita_Delete & daKita_IsDelete match

* CallbackCreateHeap match

* daKita_Create progress

* himo_create progress

* d_a_kita : small overall progress

* hand_draw match

* daShand_Draw match

* d_a_shand/control1 match except regalloc

* control2 almost done (regalloc issue)

* control3 match

* cut_control progress

* cut_control3 match

* normal progress

* cut match

* hand_move progress

* daShand_Execute match

* daShand_Delete & daShand_IsDelete match

* daShand_Create progress

* daShand_solidHeapCB match & useHeapInit progress

* daShand_HIO_c::daShand_HIO_c match

* control1 match

* control2 match

* cut_control match

* hand_move progress

* daShand_Create progress

* useHeapInit match

* Minor fixing

* renaming fields

* Merge with upstream now compiling

* cleaning up & minor fixes

* fixing string

* adding suggestions (PR #751)

* d_a_shand integration & kita_move gndchk position fix

* Removing awful cap_min_val inline

* 100% match

* Adding match to configure.py
2025-05-18 23:00:00 -04:00
WilliamArnett 28f3c8425e d_a_tag_kk1 (#755)
* 99% match

* Rewrote _execute to increase accuracy. Only issue in .text is a label not loading correctly. I have no idea how to fix this.

* Equivalent. Weak func ordering.

* Update src/d/actor/d_a_tag_kk1.cpp

Co-authored-by: LagoLunatic <LagoLunatic@users.noreply.github.com>

* Update src/d/actor/d_a_tag_kk1.cpp

Co-authored-by: LagoLunatic <LagoLunatic@users.noreply.github.com>

* Remove explicit `this`

Co-authored-by: LagoLunatic <LagoLunatic@users.noreply.github.com>

* Implemented hio_prm_c struct

---------

Co-authored-by: LagoLunatic <LagoLunatic@users.noreply.github.com>
2025-05-18 21:42:29 -04:00
Ammar Askar 094a297809 100% d_a_kui (#756)
* 45% d_a_kui

* 97% d_a_kui

* 100% d_a_kui match

* Fix easy issues from PR review

* Use s16[3] for field_0x2DC
2025-05-18 21:40:09 -04:00
LagoLunatic 337303fc79 Standardize mMode/mAction names in C-style actors 2025-05-17 14:01:12 -04:00
LagoLunatic 4a54a410b1 More player_main match fixes 2025-05-14 16:00:12 -04:00
Mattias Blum 95f230eb15 d_a_ks 100% (#746)
* initial progress

* more progress

* more progress

* more progress

* more progress

* more progress

* more progress

* more progress

* more progress

* more progress

* more progress

* more progress

* more progress

* more progress

* more progress

* more progress

* more progress

* more progress

* more progress

* more progress

* symbol cleanup

* more progress

* more progress

* d_a_ks 100%

* more symbol cleanup

* likely real-match for `useHeapInit`

* removed `csXyz` type from class member

* changed int to BOOL for `HEAVY_IN`

* documented matching issue

* PR changes
2025-05-09 15:18:16 -04:00
LagoLunatic cbbd4c2dc0 Match more player_main regalloc/stack/etc issues 2025-05-08 23:00:19 -04:00
LagoLunatic 534f5d4e72 player_crawl and player_hammer 100%, misc player cleanup 2025-05-07 23:00:35 -04:00
123456789758 224b83ed8c d_a_player_main - 96% matching (#750)
Co-authored-by: ‎ ‎ ‎ <‎ ‎ ‎>
2025-05-07 19:08:04 -04:00
LagoLunatic 74e03b6ecb Document some more TU names 2025-05-07 17:22:10 -04:00
LagoLunatic 2690304a74 player_main cleanup and a few matches 2025-04-29 15:44:49 -04:00
Jcw87 5e7b59f2fe Improve compiler compatibility (#743)
* fix returns

* use standard C headers

* struct/class mismatch

* explicit this in template

* switch variable scope

* C standard compliance

* & l-value
2025-04-29 12:49:09 -04:00
123456789758 eef20535ac d_a_player_main - 70% Matching. (#742)
Co-authored-by: ‎ ‎ ‎ <‎ ‎ ‎>
2025-04-27 19:32:36 -04:00
LagoLunatic c4eb26b2a1 d_attention cleanup, add mDoCPd inlines 2025-04-27 16:38:29 -04:00
LagoLunatic 341f329dde d_a_obj_vgnfd OK, d_a_obj_doguu OK, clean up weak-but-not-inlined funcs in finished actors 2025-04-25 18:44:45 -04:00
Zeclos 0c6c84d675 D_a_obj_doguu (#741)
* createInit for now

* _create almost _draw

* push for now, some functions finished progress on others

* _execute matches

* privatecute matching

* cleanup, almost matched

* data almost matching

* added getStartFrame to mDoExt_baseAnm, everything but data 100% matching

* cleanup and marked as Equivalent in configure.py

* cleanup
2025-04-25 17:12:32 -04:00
LagoLunatic ce8d17ec08 Add an enum for action button icon status 2025-04-20 20:06:40 -04:00
LagoLunatic f74a03109f d_a_ship documentation and inlines, couple more matches for player_ship 2025-04-17 19:06:06 -04:00
LagoLunatic 7d0c280adf player_grab 100%, cleanup 2025-04-17 00:53:33 -04:00
LagoLunatic ad22472b1a player misc cleanup and various match fixes 2025-04-16 20:26:40 -04:00
LagoLunatic 3a9eebd7ea player_sword 100%, cleanup 2025-04-16 17:39:21 -04:00
LagoLunatic 38a6e76657 player checkFlg inline fix, player_pushpull cleanup 2025-04-16 16:50:11 -04:00
LagoLunatic be81e109e9 One more player inline 2025-04-16 15:07:00 -04:00
LagoLunatic ce1468c108 player enum and inlines and goto cleanup 2025-04-16 15:02:18 -04:00
Zeclos 35f479ae33 D_a_obj_iceisland (#740)
* 100% matching

* cleanup

* cleanup, removed old comment
2025-04-15 03:34:55 -04:00
123456789758 70d9f5df10 d_a_player_main - 48% Matching. (#739)
Co-authored-by: ‎ ‎ ‎ <‎ ‎ ‎>
2025-04-14 17:17:47 -04:00
LagoLunatic 6aeaaef643 Added enum for Link's movement direction 2025-04-11 15:02:53 -04:00
LagoLunatic 309158e274 J3DModel inlines cleanup, procBottleSwing_init match, etc 2025-04-10 19:30:51 -04:00
Zeclos 0bb7ff4051 D_a_obj_smplbg (#738)
* small push

* everything is moslty matching

* logic matches, data doesnt

* 100% matching

* cleanup
2025-04-10 16:14:09 -04:00
LagoLunatic 556e578f23 Misc small cleanup 2025-04-09 01:49:35 -04:00
123456789758 072cb3a441 d_a_player_misc - Several matches/close matches across several files. (#736)
Co-authored-by: ‎ ‎ ‎ <‎ ‎ ‎>
2025-04-08 17:41:27 -04:00
LagoLunatic cd777aa35b object-particle OK 2025-04-08 17:03:42 -04:00
‎ ‎ ‎ d3c253dcef d_a_player_rope.inc - Almost all matching except minor issues (also extra matches in d_a_player_vomit). 2025-04-05 22:14:32 -04:00
LagoLunatic 6d7550f14a player_whide 100%, player_ship fixes 2025-04-04 15:37:16 -04:00
LagoLunatic 924e87029d d_a_player_sword cleanup and small match fixes 2025-04-04 13:19:42 -04:00
LagoLunatic cda3f0c302 d_a_player_battle 100% 2025-04-03 17:56:52 -04:00
Zeclos d16ee29425 D a w bird (#733)
* create functions

* actionend matched

* matched a func i think. progress on setstartpos

* progress on  setstartpos, 2 small functions done

* rodata + actionselect

* 100% match

* cleanup

* configure.py matching

* removed unecessary cast

* removes the linker warning from arcname

* added the setaction inline. moved logic

* setAction now takes unsigned char
2025-04-03 17:34:13 -04:00
LagoLunatic 458d027fc9 d_a_hookshot equivalent 2025-04-02 15:54:23 -04:00
LagoLunatic 4f6533b871 hookshot and player_hook cleanup, inlines 2025-04-01 23:25:03 -04:00
LagoLunatic f2ff19c83e player_fan 99% 2025-04-01 20:46:23 -04:00
LagoLunatic bc4c7dd5f9 Match Link's HIO class constructor
The constructor and section ordering of the constructor both seem to match now.
2025-04-01 16:03:06 -04:00