* Match up d_a_npc_bmsw to 98%
* Remove old nonmatching comments
* Match MailCreateInit by using a static cast
* Match Throw and daNpc_Bmsw_getGameEndMsg
* Match CreateInit using demo for ref
* Fix inline for dComIfG_TimerStart
* Match shiwake_game_action
* Match getNextNo
* Mark Equivalent
* Fully match d_a_npc_btsw and mark equivelant
---------
Co-authored-by: LagoLunatic <LagoLunatic@users.noreply.github.com>
* Match up d_a_npc_bmsw to 98%
* Remove old nonmatching comments
* Match MailCreateInit by using a static cast
* Match Throw and daNpc_Bmsw_getGameEndMsg
* Match CreateInit using demo for ref
* Fix inline for dComIfG_TimerStart
* Match shiwake_game_action
* Match getNextNo
* Mark Equivalent
* implement daObjTable functions
* matches now in build, 100%
* use inlines and make it cleaner
* inlines
* add only retail match
---------
Co-authored-by: Onni <mail@onnileivo.com>
* Demo work
* Fix PAL
* Fix d_door weak func order and link it
* Fix d_door for demo
* JKernel OK on demo + misc
* tag_attention 100% on demo
* More demo work and fix some retail fakematches
* #181: d_a_tag_attention matching; TODO: implement chk_inside and dComIfGp_att_Look2RequestF
* #181: continue working on d_a_tag_attention, matching almost complete
* #181: revert naming class member (not certain enough)
* #181: preliminary changes to resolve#784 comments regarding usage of debug maps
* #181: commit suggestion by @WilliamArnett, fixing regalloc error
Co-authored-by: WilliamArnett <149556961+WilliamArnett@users.noreply.github.com>
* #181: fix missing curly bracket
* #181: resolve#784 comments with the kind help of @WilliamArnett;
move `daTagAttention::Act_c::chk_inside` to header file; split `plyrToObjVec` definition to match assembly;
remove temp variable, use values directly and swap operands;
implement `Look2RequestF` in `include/d/d_attention.h`;
remove non-matching use of temp variable `iVar1` and replace `current.pos` with uninitialized variable in `daTagAttention::Act_c::_execute`
* Update include/d/actor/d_a_tag_attention.h
Co-authored-by: WilliamArnett <149556961+WilliamArnett@users.noreply.github.com>
* #181: update `d_a_tag_attention` to `Matching` in `configure.py`; remove Non-Matching comments
* #181: change matching type to `Equivalent` for `d_a_tag_attention`
* Apply suggestions from code review
Co-authored-by: LagoLunatic <LagoLunatic@users.noreply.github.com>
* #181: fix PrmAbstract call
---------
Co-authored-by: WilliamArnett <149556961+WilliamArnett@users.noreply.github.com>
Co-authored-by: LagoLunatic <LagoLunatic@users.noreply.github.com>
* 99% match
* Rewrote _execute to increase accuracy. Only issue in .text is a label not loading correctly. I have no idea how to fix this.
* Equivalent. Weak func ordering.
* 7% text
* 28% text
* 41% text
* 65% text
* Rewrote _execute to increase accuracy. Only issue in .text is a label not loading correctly. I have no idea how to fix this.
* Equivalent. Weak func ordering.
* 82% text
* Equivalent. A lot of work is needed to name variables and clean up functions. Weak function ordering is wrong.
* Cleaned some functions, named several variables, and began documenting dialog tree.
* Naming a couple more variables
* 21% text
* change out getMySubstanceP for getMyIntegerP inline
* 100% text
* Refactor to use JUT_ASSERT macro
* Revert merges
* Revert "Merge branch 'main' into d_a_npc_km1"
This reverts commit 9ebc35f76b, reversing
changes made to b8807b2f50.
* Revert merges
* Revert "Merge branch 'main' into d_a_npc_km1"
This reverts commit 9ebc35f76b, reversing
changes made to b8807b2f50.
* Undo file changes
* Revert "Undo file changes"
This reverts commit 5bcc47fcd4.
* a couple more reverts
* Should be done with reverts
* revert configure.py
* Implement LagoLunatic's suggested changes
* add endif to allow demo to build
* Start matching up d_a_bst
* Commit more progress on d_a_bst
* Match up more functions
* Match up stay function
* Remove some questionable names
* Match fly and some attack functions
* Match collider data
* Address feedback from review
* Fix no-op actor calls and match some functions better
* bit too difficult for me for now, might go back later
* progress
* getmsg
* logic matching data isnt
* data section matches
* mathubcg 100%
* cleanup
* revert this change
* final cleanup and configure.py
* nevermind cleanup
* Equivalent onstead of matching
* removed padding
* cleanup code comments and a bit more
* close to matching
* matches
* added d/d_priority.h back
* configure.pu
* updated to match retail and cleanup
* bit too difficult for me for now, might go back later
* progress
* getmsg
* logic matching data isnt
* data section matches
* mathubcg 100%
* cleanup
* revert this change
* final cleanup and configure.py
* nevermind cleanup
* Equivalent onstead of matching
* removed padding
* cleanup code comments and a bit more
* Fix build
---------
Co-authored-by: LagoLunatic <LagoLunatic@users.noreply.github.com>
* Do initial work on d_a_jbo
* Remove outdated comments
* Move co_sph_src to be a function static variable
* Mark as matching
* Rename mParamsLower to mParam
* Give names to mFramesUntilJump, mAnimRotation, mAnimationSpeed, mParticlePos
* Give jbo_class::mState an enum
* fixup! Give names to mFramesUntilJump, mAnimRotation, mAnimationSpeed, mParticlePos
* Give resource ids an enum
* Add documentation comment for actor
* MWCC shenanigans
* Rename variables to better match coding guidelines
* Apply suggestions from code review
- use J3DModel::setBaseScale() inline
- use existing resource id enum
- rename `i_actor` -> `i_this`, `that` -> `a_this`
- use defines for missed returned booleans
- replace `mDoAud_seStart` -> `fopAcM_seStart`
Co-Authored-By: LagoLunatic <LagoLunatic@users.noreply.github.com>
* Apply rest of inlines
i must have forgotten about them earlier
---------
Co-authored-by: LagoLunatic <LagoLunatic@users.noreply.github.com>
* ride_call_back progress
* daKita_Draw match
* kita_move progress
* ride_call_back match
* daKita_Execute will match
* daKita_Delete & daKita_IsDelete match
* CallbackCreateHeap match
* daKita_Create progress
* himo_create progress
* d_a_kita : small overall progress
* hand_draw match
* daShand_Draw match
* d_a_shand/control1 match except regalloc
* control2 almost done (regalloc issue)
* control3 match
* cut_control progress
* cut_control3 match
* normal progress
* cut match
* hand_move progress
* daShand_Execute match
* daShand_Delete & daShand_IsDelete match
* daShand_Create progress
* daShand_solidHeapCB match & useHeapInit progress
* daShand_HIO_c::daShand_HIO_c match
* control1 match
* control2 match
* cut_control match
* hand_move progress
* daShand_Create progress
* useHeapInit match
* Minor fixing
* renaming fields
* Merge with upstream now compiling
* cleaning up & minor fixes
* fixing string
* adding suggestions (PR #751)
* d_a_shand integration & kita_move gndchk position fix
* Removing awful cap_min_val inline
* 100% match
* Adding match to configure.py
* 99% match
* Rewrote _execute to increase accuracy. Only issue in .text is a label not loading correctly. I have no idea how to fix this.
* Equivalent. Weak func ordering.
* Update src/d/actor/d_a_tag_kk1.cpp
Co-authored-by: LagoLunatic <LagoLunatic@users.noreply.github.com>
* Update src/d/actor/d_a_tag_kk1.cpp
Co-authored-by: LagoLunatic <LagoLunatic@users.noreply.github.com>
* Remove explicit `this`
Co-authored-by: LagoLunatic <LagoLunatic@users.noreply.github.com>
* Implemented hio_prm_c struct
---------
Co-authored-by: LagoLunatic <LagoLunatic@users.noreply.github.com>
* initial progress
* more progress
* more progress
* more progress
* more progress
* more progress
* more progress
* more progress
* more progress
* more progress
* more progress
* more progress
* more progress
* more progress
* more progress
* more progress
* more progress
* more progress
* more progress
* more progress
* symbol cleanup
* more progress
* more progress
* d_a_ks 100%
* more symbol cleanup
* likely real-match for `useHeapInit`
* removed `csXyz` type from class member
* changed int to BOOL for `HEAVY_IN`
* documented matching issue
* PR changes
LagoLunatic