0837af95c3
game: ensure SDL subsystems are cleaned up prior to quitting SDL ( #3913 )
...
For dualsense controllers, when the game exits we explicitly clear any
trigger effects. This was happening after SDL was already terminated, so
the hardware handles were already lost.
From a practical standpoint though, this mostly just cleans up logs.
2025-05-13 17:51:00 -04:00
85e3203188
g/jak2: don't try to print subtitles that don't exist (non-base language) ( #3910 )
...
Fixes #3909
Long standing issue in Jak 2's subtitles, it's actually kinda incredible
that finnish didn't run into this problem. Later in this code it
accesses the subtitle based on the language-id, and finnish is always
out of bounds -- but it never caused a catastrophic issue.
Polish on the otherhand is much more out of bounds and always causes an
access violation / crash.
Jak 2's subtitle code has no fallback (ie. use english if not
translated) for cutscenes, since they are not defined in the base file
like in Jak 1. This means that an untranslated language will render no
subtitles during cutscenes. Translations are welcome!.
Tested a cutscene in:
- english
- italian (base game with subtitles)
- finnish (new language, actually is translated)
- polish (new language, not translated)
2025-05-12 22:41:48 -04:00
5873c881e1
Hide imgui only on key press, instead of while pressed. ( #3911 )
...
The imgui bar is currently toggled repeatedly if the key is held down,
this can lead to annoyances where the key is held for a short time and
cycles back to "show" or "hide" when that's not what the user wants.
Current behavior:
https://github.com/user-attachments/assets/5d719364-9949-4ba2-bf72-7d432650a614
Fixed behavior
https://github.com/user-attachments/assets/b816f502-c155-4d86-adb7-41ca1a7a40cf
2025-05-12 21:58:41 -04:00
032142323a
CI: Periodic Controller Database Update ( #3912 )
...
Updating Controller Database
Co-authored-by: OpenGOALBot <OpenGOALBot@users.noreply.github.com >
2025-05-12 20:54:41 -04:00
67f62560af
g/j2: change and initialize jak 2 subtitles correctly ( #3907 )
...
Fixes #3906
Wasn't an issue on Jak 1 because that game had no original subtitles,
but jak 2's subtitles still go through their original code, which uses
the `*setting-control*` object. This is a regression from when i
recently added all languages to the menu options.
- Update the setting at runtime
- Update the setting at initialization time
This may be an issue in Jak 3 as well if the code was copied over. We'll
fix it when we get there.
2025-05-09 21:37:05 -04:00
c1480cdaa4
CI: Periodic Controller Database Update ( #3900 )
...
Updating Controller Database
Co-authored-by: OpenGOALBot <OpenGOALBot@users.noreply.github.com >
2025-05-09 16:51:46 -04:00
5d9a760ee5
build(deps): bump hendrikmuhs/ccache-action from 1.2.17 to 1.2.18 ( #3903 )
...
Bumps
[hendrikmuhs/ccache-action](https://github.com/hendrikmuhs/ccache-action )
from 1.2.17 to 1.2.18.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/hendrikmuhs/ccache-action/releases ">hendrikmuhs/ccache-action's
releases</a>.</em></p>
<blockquote>
<h2>v1.2.18</h2>
<h2>What's Changed</h2>
<ul>
<li>Bump ts-jest from 29.2.5 to 29.2.6 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/hendrikmuhs/ccache-action/pull/291 ">hendrikmuhs/ccache-action#291</a></li>
<li>Bump typescript from 5.7.3 to 5.8.2 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/hendrikmuhs/ccache-action/pull/294 ">hendrikmuhs/ccache-action#294</a></li>
<li>Bump <code>@types/node</code> from 22.13.0 to 22.13.9 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/hendrikmuhs/ccache-action/pull/296 ">hendrikmuhs/ccache-action#296</a></li>
<li>set cache to readonly if skipping save by <a
href="https://github.com/planetmarshall "><code>@planetmarshall</code></a>
in <a
href="https://redirect.github.com/hendrikmuhs/ccache-action/pull/301 ">hendrikmuhs/ccache-action#301</a></li>
<li>Update sccache version to v0.10.0 by <a
href="https://github.com/mhegazy "><code>@mhegazy</code></a> in <a
href="https://redirect.github.com/hendrikmuhs/ccache-action/pull/315 ">hendrikmuhs/ccache-action#315</a></li>
<li>Bump <code>@types/node</code> from 22.13.9 to 22.15.2 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/hendrikmuhs/ccache-action/pull/316 ">hendrikmuhs/ccache-action#316</a></li>
<li>Bump ts-jest from 29.2.6 to 29.3.2 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/hendrikmuhs/ccache-action/pull/312 ">hendrikmuhs/ccache-action#312</a></li>
<li>Bump typescript from 5.8.2 to 5.8.3 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/hendrikmuhs/ccache-action/pull/311 ">hendrikmuhs/ccache-action#311</a></li>
<li>Bump <code>@actions/cache</code> from 4.0.0 to 4.0.3 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/hendrikmuhs/ccache-action/pull/299 ">hendrikmuhs/ccache-action#299</a></li>
<li>Don't append <code>-</code> when <code>append-timestamp</code> is
disabled. by <a href="https://github.com/Naros "><code>@Naros</code></a>
in <a
href="https://redirect.github.com/hendrikmuhs/ccache-action/pull/306 ">hendrikmuhs/ccache-action#306</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/mhegazy "><code>@mhegazy</code></a> made
their first contribution in <a
href="https://redirect.github.com/hendrikmuhs/ccache-action/pull/315 ">hendrikmuhs/ccache-action#315</a></li>
<li><a href="https://github.com/Naros "><code>@Naros</code></a> made
their first contribution in <a
href="https://redirect.github.com/hendrikmuhs/ccache-action/pull/306 ">hendrikmuhs/ccache-action#306</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/hendrikmuhs/ccache-action/compare/v1...v1.2.18 ">https://github.com/hendrikmuhs/ccache-action/compare/v1...v1.2.18 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/hendrikmuhs/ccache-action/commit/63069e3931dedbf3b63792097479563182fe70d1 "><code>63069e3</code></a>
update code</li>
<li><a
href="https://github.com/hendrikmuhs/ccache-action/commit/15457da8f7bbf9b2c71f2efebd847c1a84650208 "><code>15457da</code></a>
Don't append <code>-</code> when <code>append-timestamp</code> is
disabled. (<a
href="https://redirect.github.com/hendrikmuhs/ccache-action/issues/306 ">#306</a>)</li>
<li><a
href="https://github.com/hendrikmuhs/ccache-action/commit/25d49ca51adf245e1fc66fbf5485fa70ff353f64 "><code>25d49ca</code></a>
update code</li>
<li><a
href="https://github.com/hendrikmuhs/ccache-action/commit/5107eae3c4885a3f516e7b3391c85539abee811c "><code>5107eae</code></a>
Bump <code>@actions/cache</code> from 4.0.0 to 4.0.3 (<a
href="https://redirect.github.com/hendrikmuhs/ccache-action/issues/299 ">#299</a>)</li>
<li><a
href="https://github.com/hendrikmuhs/ccache-action/commit/0be57ad590dbc0ddc23d1915149acb8d1d035482 "><code>0be57ad</code></a>
Bump typescript from 5.8.2 to 5.8.3 (<a
href="https://redirect.github.com/hendrikmuhs/ccache-action/issues/311 ">#311</a>)</li>
<li><a
href="https://github.com/hendrikmuhs/ccache-action/commit/82ea68836f4698bbc2a53332fb4357aec9fe5a80 "><code>82ea688</code></a>
Bump ts-jest from 29.2.6 to 29.3.2 (<a
href="https://redirect.github.com/hendrikmuhs/ccache-action/issues/312 ">#312</a>)</li>
<li><a
href="https://github.com/hendrikmuhs/ccache-action/commit/1442e5b70da90a19cbbe567fa450d6349b819e41 "><code>1442e5b</code></a>
Bump ts-jest from 29.2.6 to 29.3.2 (<a
href="https://redirect.github.com/hendrikmuhs/ccache-action/issues/312 ">#312</a>)</li>
<li><a
href="https://github.com/hendrikmuhs/ccache-action/commit/e3bfc65f9cf257b6332793c3d965c05100350a6e "><code>e3bfc65</code></a>
Bump <code>@types/node</code> from 22.13.9 to 22.15.2 (<a
href="https://redirect.github.com/hendrikmuhs/ccache-action/issues/316 ">#316</a>)</li>
<li><a
href="https://github.com/hendrikmuhs/ccache-action/commit/fc9101105b417abd4b0a58457a3d0327aa1fa597 "><code>fc91011</code></a>
Update sccache version to v0.10.0 (<a
href="https://redirect.github.com/hendrikmuhs/ccache-action/issues/315 ">#315</a>)</li>
<li><a
href="https://github.com/hendrikmuhs/ccache-action/commit/15fe4dd483de6883ed9b919e77778f61f69fc053 "><code>15fe4dd</code></a>
set cache to readonly if skipping save (<a
href="https://redirect.github.com/hendrikmuhs/ccache-action/issues/301 ">#301</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/hendrikmuhs/ccache-action/compare/v1.2.17...v1.2.18 ">compare
view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-05-09 16:51:39 -04:00
4e28bd1eaf
[jak1] Speedrun mode misc fixes ( #3902 )
...
Fixed up a few things for speedrun mode in Jak 1:
- Changed autosplitter to start run in line with ruleset (first frame
after blackout where jak is touching ground). Also tweaked the
verification text in bottom left to show "Run Started: Yes/No" to go
with this
- Changed speedrun menu button combo to match Jak 2/3 (only need to hold
L1+R1 and press Start/Select, no longer need to hold X)
- Treat speedrun menu via Select the same as Start (no more potential
for funny pause buffer where actors freeze)
warp gate example:
already grounded example (run starts once partially out of blackout):
2025-04-26 23:23:55 +02:00
3906262fd4
Toggle Cpp openGL with F12 / Alt + Enter / Anything else ( #3901 )
...
This is a successor to #3230
---------
Co-authored-by: Hat Kid <6624576+Hat-Kid@users.noreply.github.com >
2025-04-26 23:17:27 +02:00
c61a69d751
jak3: wip pc progress code ( #3898 )
2025-04-16 20:57:43 +02:00
7a086fcadb
CI: Periodic Controller Database Update ( #3897 )
...
Updating Controller Database
Co-authored-by: OpenGOALBot <OpenGOALBot@users.noreply.github.com >
2025-04-14 19:01:01 -04:00
a1d1ff139b
Fix for running extractor without optional game flag ( #3896 )
...
Co-authored-by: Tyler Wilding <xtvaser@gmail.com >
2025-04-13 00:42:50 -04:00
647282d896
deps: update fmt to 11.1.4 ( #3880 )
...
Fixes #3886
2025-04-12 15:59:13 -04:00
5415c83def
CI: Periodic Controller Database Update ( #3894 )
...
Updating Controller Database
Co-authored-by: OpenGOALBot <OpenGOALBot@users.noreply.github.com >
2025-04-09 23:10:20 -04:00
e122941ede
Fix pagination for non-dynamic popup menus (speedrun menu) ( #3883 )
...
Was testing out adding ILs to the speedrun menu and noticed this wasn't
working properly
(video before the changes)
https://github.com/user-attachments/assets/e1e7f443-60d2-4b15-bc27-a20cbe4442d6
Co-authored-by: Tyler Wilding <xtvaser@gmail.com >
2025-03-31 15:40:40 -04:00
6871a3a067
goalc: don't assume DGO/CGOs are within the ObjectDB when building levels ( #3888 )
...
Follow-up later on improving the validation of the extractor (that may
require testing with all iso versions), but this is just some simple
safe-guarding code that will improve the error messaging, instead of
just a vague invalid map error.
2025-03-31 15:40:25 -04:00
46b91e5ee5
Merge pull request #3884 from open-goal/bot/update-controller-db
...
CI: Periodic Controller Database Update
2025-03-30 13:20:37 -04:00
1fa9363414
ci: updated controller database
2025-03-24 16:23:09 +00:00
61ad9f08cd
Extract levels+collision to decompiler_out (adjacent to textures+audio) ( #3882 )
...
should make it nice and easy to jump to the `decompiler_out/<game>`
folder in the launcher and show the user all their exported things.
also adds a taskfile command for ripping audio.
and fixes jak1 collision extract scaling. I [previously fixed this for
jak2/3](https://github.com/open-goal/jak-project/pull/3292#discussion_r1442595308 )
but never fixed for jak1 apparently
before:
after:
2025-03-24 14:26:58 +01:00
ea3d2308f8
Merge pull request #3877 from open-goal/bot/update-controller-db
...
CI: Periodic Controller Database Update
2025-03-10 16:36:55 -04:00
6696346f77
ci: updated controller database
2025-03-10 16:19:20 +00:00
3e6ba273f7
Dedupe custom level textures by height/width/data, not just name ( #3874 )
...
I fixed this for the only up mod awhile back and forgot to PR it here.
Some related discussion
[here](https://discord.com/channels/756287461377703987/995787558816595968/1320482071583522878 )
where we realized Blender automatically "renames" the textures, but then
the GLB export doesn't reflect those renames
2025-03-08 23:21:16 +01:00
1f6438e517
deps: update to SDL3 ( #3852 )
...
This PR updates to SDL3, and with it, adds a handful of new features.
Everything seems to work but I'm going to look over the code once last
time before merging, some of the API changes are hard to spot.
Fixes #2773
### Pressure sensitivity support for DS3 Controllers
SDL3 adds pressure sensitivity support for DS3 controllers on windows. I
have not tested on linux. The option is disabled by default.
On windows you will need https://docs.nefarius.at/projects/DsHidMini/
and to be using SXS mode.
### DualSense and Xbox One Trigger Effects
If enabled, Jak 2 will have certain trigger effects. They are:
- xbox1:
- small vibrate when collecting dark eco
- big vibrate when changing to dark jak
- vibrate when shooting gun, proportional to gun type
- ps5:
- resistance when changing to dark jak
- different gun shooting effects
- red (resistance)
- yellow (weapon trigger)
- blue (vibrates)
- purple (less resistance)
> **Gun Shooting effects are only enabled if the new "Swap R1 and R2"
option is enabled**
There are more effects that could be used in `dualsense_effects.cpp`,
but I only exposed the ones I needed to OpenGOAL. If a modder wants to
use some of the others and wires them up end-to-end, please consider
contributing that upstream.
### New ImGUI Menu
Added new imgui options for selecting the active controller, for those
people that struggle to select the initial controller.
### Testing
The highlights of what I tested successfully:
- display
- [x] all mode switch permutations
- [x] launch with all modes saved
- [x] switch monitors / unplug monitor that was active, how does it
handle it
- [x] load with alternate monitor saved and all modes
- [x] allowing hidpi doesnt break macos
- controls
- [x] keyboard and mouse still work
- [x] pressure sensitivity on linux
2025-03-02 16:36:22 -05:00
651b5b2a93
build-actor: fix merc transparency ( #3875 )
...
Because merc effects for custom models would always have the
`envmap-usage` flag set, this would also set the `ignore-alpha` flag,
making transparency effects not work. Now the envmap flag is only set
when the effect actually has an envmap.
2025-03-02 22:06:22 +01:00
b2289e844c
g/j2: persist subtitle language properly, eliminates a crash ( #3872 )
...
Fixes #3870
2025-03-01 13:17:38 -05:00
ccbd6008d2
build(deps): bump hendrikmuhs/ccache-action from 1.2.16 to 1.2.17 ( #3868 )
...
Bumps
[hendrikmuhs/ccache-action](https://github.com/hendrikmuhs/ccache-action )
from 1.2.16 to 1.2.17.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/hendrikmuhs/ccache-action/releases ">hendrikmuhs/ccache-action's
releases</a>.</em></p>
<blockquote>
<h2>v1.2.17</h2>
<h2>What's Changed</h2>
<ul>
<li>support Ubuntu arm64 runners with sccache variant by <a
href="https://github.com/andrurogerz "><code>@andrurogerz</code></a> in
<a
href="https://redirect.github.com/hendrikmuhs/ccache-action/pull/280 ">hendrikmuhs/ccache-action#280</a></li>
<li>Bump <code>@types/node</code> from 22.10.5 to 22.10.10 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/hendrikmuhs/ccache-action/pull/282 ">hendrikmuhs/ccache-action#282</a></li>
<li>Bump <code>@types/node</code> from 22.10.10 to 22.13.0 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/hendrikmuhs/ccache-action/pull/285 ">hendrikmuhs/ccache-action#285</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a
href="https://github.com/andrurogerz "><code>@andrurogerz</code></a>
made their first contribution in <a
href="https://redirect.github.com/hendrikmuhs/ccache-action/pull/280 ">hendrikmuhs/ccache-action#280</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/hendrikmuhs/ccache-action/compare/v1.2.16...v1.2.17 ">https://github.com/hendrikmuhs/ccache-action/compare/v1.2.16...v1.2.17 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/hendrikmuhs/ccache-action/commit/a1209f81afb8c005c13b4296c32e363431bffea5 "><code>a1209f8</code></a>
Bump <code>@types/node</code> from 22.10.10 to 22.13.0 (<a
href="https://redirect.github.com/hendrikmuhs/ccache-action/issues/285 ">#285</a>)</li>
<li><a
href="https://github.com/hendrikmuhs/ccache-action/commit/a6067e2292150bdcfe1a16a5d8ddcc403109ea40 "><code>a6067e2</code></a>
Bump <code>@types/node</code> from 22.10.5 to 22.10.10 (<a
href="https://redirect.github.com/hendrikmuhs/ccache-action/issues/282 ">#282</a>)</li>
<li><a
href="https://github.com/hendrikmuhs/ccache-action/commit/433beb5b585c67c13415f39d5ba7e485b1920710 "><code>433beb5</code></a>
support Ubuntu arm64 runners with sccache variant (<a
href="https://redirect.github.com/hendrikmuhs/ccache-action/issues/280 ">#280</a>)</li>
<li>See full diff in <a
href="https://github.com/hendrikmuhs/ccache-action/compare/v1.2.16...v1.2.17 ">compare
view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-28 21:56:35 -05:00
3c5b1fbfba
New Crowdin updates - February 2024 ( #3867 )
2025-02-28 21:41:36 -05:00
9759841e3b
New Crowdin updates - February 2024 ( #3857 )
2025-02-28 19:31:50 -05:00
04a10b27cd
CI: Periodic Controller Database Update ( #3865 )
...
Updating Controller Database
Co-authored-by: OpenGOALBot <OpenGOALBot@users.noreply.github.com >
2025-02-27 21:16:11 -05:00
e656ef943b
Jak 2: Italian translation (Hints) ( #3590 )
...
Used a PR since many things can't be changed using Crowdin, such as
timings.
Same team as the italian Jak 1 translation.
This PR won't include subtitles, which will be included later on in a
separate PR, once things will be worked on.
Still needs to be revised by the team.
---------
Co-authored-by: pex93 <44973506+pex93@users.noreply.github.com >
Co-authored-by: Francesco <107510301+XedoIT@users.noreply.github.com >
Co-authored-by: Tyler Wilding <xtvaser@gmail.com >
2025-02-17 00:56:00 -05:00
41ed4b1d7e
ci: update to ubuntu 22.04 ( #3860 )
...
Ubuntu 20.04 is hitting it's next EOL stage in april
https://endoflife.date/ubuntu
And it's being removed from github actions in april to go along with
that
https://github.blog/changelog/2025-01-15-github-actions-ubuntu-20-runner-image-brownout-dates-and-other-breaking-changes/
Getting ahead of this before we have random failures, I'll update the
launcher along with this change for this month.
On the bright side, we can finally update clang-format!
2025-02-16 17:40:52 -05:00
23118be428
[jak3] Fix crash in subrails ( #3863 )
...
After the change to vector ops, subrails was crashing. This fixes the
crash by fixing a stack type and also marks those new vector op
functions as inline.
Co-authored-by: water111 <awaterford1111445@gmail.com >
2025-02-16 17:40:23 -05:00
af9a8dd7f1
[graphics] Fix issue with envmap math ( #3862 )
...
A few people in the discord noticed that the shiny part of the subrails
looks different between PS2 and OpenGOAL. I looked into this and found a
bug where the length of the normals was half what they should have been.
Earlier this didn't matter because I normalized them in the shader, but
at some point I removed that when refactoring other parts.
I'm not completely convinced we have the intensity/tint multiplier
working correctly, but this is at least a step in the right direction.
https://github.com/user-attachments/assets/ee754011-08ac-4bee-94b2-d0e114b952ec
https://github.com/user-attachments/assets/1079635a-0b92-4965-a991-972ef6048ddf
For fun, here's this fix, plus a random doubling of the envmap effect
strength:
https://github.com/user-attachments/assets/726e7b8d-c020-42cf-a594-cad590c0ef7d
---------
Co-authored-by: water111 <awaterford1111445@gmail.com >
2025-02-16 16:58:11 -05:00
2a4d3d7a4a
[decompiler] More inline vector functions ( #3861 )
...
This adds more recognition for inlined vector functions to the
decompiler, which can clean up a bunch of ugly looking code/`rlet`s.
Unfortunately, this changes the numbering of ops in the decomp, since
all the vector instructions get combined in a single "operation" by the
decompiler. I really tried to avoid having this ever happen in the
decompiler and this is one of the few cases where it has. So I had to
update a bunch of type casts.
For that reason I haven't turned this on in Jak 2 yet, although I am
planning to do that at some point. (probably at the same time as porting
back a bunch of jak 3 improvements to jak 2)
---------
Co-authored-by: water111 <awaterford1111445@gmail.com >
2025-02-16 15:59:17 -05:00
b07d0d9ced
CI: Periodic Controller Database Update ( #3856 )
...
Updating Controller Database
Co-authored-by: OpenGOALBot <OpenGOALBot@users.noreply.github.com >
2025-02-15 22:39:29 -05:00
48cb9bb787
[decompiler] as-type and font method support ( #3855 )
...
Add support for `as-type` macro, and detecting inline font methods. This
works in all three games but I've only updated jak 3's goal_src for now.
Eventually I will go back and work through the others, but I want to get
more decompiler features in first.
---------
Co-authored-by: water111 <awaterford1111445@gmail.com >
2025-02-01 21:23:11 -05:00
d5590ab638
build(deps): bump hendrikmuhs/ccache-action from 1.2.14 to 1.2.16 ( #3854 )
...
Bumps
[hendrikmuhs/ccache-action](https://github.com/hendrikmuhs/ccache-action )
from 1.2.14 to 1.2.16.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/hendrikmuhs/ccache-action/releases ">hendrikmuhs/ccache-action's
releases</a>.</em></p>
<blockquote>
<h2>v1.2.16</h2>
<h2>What's Changed</h2>
<ul>
<li>Change Bash to Shell everywhere by <a
href="https://github.com/hansfn "><code>@hansfn</code></a> in <a
href="https://redirect.github.com/hendrikmuhs/ccache-action/pull/223 ">hendrikmuhs/ccache-action#223</a></li>
<li>Add option to add stats to Job Summary page by <a
href="https://github.com/planetmarshall "><code>@planetmarshall</code></a>
in <a
href="https://redirect.github.com/hendrikmuhs/ccache-action/pull/263 ">hendrikmuhs/ccache-action#263</a></li>
<li>Evict old files from the cache prior to saving by <a
href="https://github.com/planetmarshall "><code>@planetmarshall</code></a>
in <a
href="https://redirect.github.com/hendrikmuhs/ccache-action/pull/270 ">hendrikmuhs/ccache-action#270</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a
href="https://github.com/planetmarshall "><code>@planetmarshall</code></a>
made their first contribution in <a
href="https://redirect.github.com/hendrikmuhs/ccache-action/pull/263 ">hendrikmuhs/ccache-action#263</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/hendrikmuhs/ccache-action/compare/v1...v1.2.16 ">https://github.com/hendrikmuhs/ccache-action/compare/v1...v1.2.16 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/hendrikmuhs/ccache-action/commit/53911442209d5c18de8a31615e0923161e435875 "><code>5391144</code></a>
Revert <a
href="https://redirect.github.com/hendrikmuhs/ccache-action/issues/273 ">#273</a>
(<a
href="https://redirect.github.com/hendrikmuhs/ccache-action/issues/276 ">#276</a>)</li>
<li><a
href="https://github.com/hendrikmuhs/ccache-action/commit/10832139bf774c2772bd272b9965661f650cc03d "><code>1083213</code></a>
update code</li>
<li><a
href="https://github.com/hendrikmuhs/ccache-action/commit/f2e06a04a5f6407f80d5b08979a45824a2c95674 "><code>f2e06a0</code></a>
Bump <code>@actions/cache</code> from 3.3.0 to 4.0.0 (<a
href="https://redirect.github.com/hendrikmuhs/ccache-action/issues/268 ">#268</a>)</li>
<li><a
href="https://github.com/hendrikmuhs/ccache-action/commit/d10405245044a4399effebdfc1ae28cbaa1231f9 "><code>d104052</code></a>
Bump typescript from 5.7.2 to 5.7.3 (<a
href="https://redirect.github.com/hendrikmuhs/ccache-action/issues/275 ">#275</a>)</li>
<li><a
href="https://github.com/hendrikmuhs/ccache-action/commit/f5df2923b5a63919a669a730a8795f719f700bdc "><code>f5df292</code></a>
Use sudo (if available) when installing sccache (<a
href="https://redirect.github.com/hendrikmuhs/ccache-action/issues/273 ">#273</a>)</li>
<li><a
href="https://github.com/hendrikmuhs/ccache-action/commit/d535f91810e6ff57acce500c7992765d9bc05a33 "><code>d535f91</code></a>
Bump <code>@types/node</code> from 22.10.2 to 22.10.5 (<a
href="https://redirect.github.com/hendrikmuhs/ccache-action/issues/272 ">#272</a>)</li>
<li><a
href="https://github.com/hendrikmuhs/ccache-action/commit/e7a0524ab2c2f3d668e20aced36205fa717e29b9 "><code>e7a0524</code></a>
Evict old files from the cache prior to saving (<a
href="https://redirect.github.com/hendrikmuhs/ccache-action/issues/270 ">#270</a>)</li>
<li><a
href="https://github.com/hendrikmuhs/ccache-action/commit/c7704b4bd5fc9171d8e26073444d7779d90cde3c "><code>c7704b4</code></a>
Bump <code>@types/node</code> from 22.10.1 to 22.10.2 (<a
href="https://redirect.github.com/hendrikmuhs/ccache-action/issues/269 ">#269</a>)</li>
<li><a
href="https://github.com/hendrikmuhs/ccache-action/commit/6f387851dc686da4ddc9833a1d7085535bd4d02f "><code>6f38785</code></a>
Add option to add stats to Job Summary page (<a
href="https://redirect.github.com/hendrikmuhs/ccache-action/issues/263 ">#263</a>)</li>
<li><a
href="https://github.com/hendrikmuhs/ccache-action/commit/5f65b4d9dc6aafa5e9aedece06f7c06f2974af86 "><code>5f65b4d</code></a>
Bump <code>@types/node</code> from 22.10.0 to 22.10.1 (<a
href="https://redirect.github.com/hendrikmuhs/ccache-action/issues/267 ">#267</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/hendrikmuhs/ccache-action/compare/v1.2.14...v1.2.16 ">compare
view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-02-01 15:22:08 -05:00
710f3ac117
custom levels: etie and build actor support for jak2/3 ( #3851 )
...
Custom levels for Jak 2/3 now support envmapped TIE geometry. The TIE
extract was also changed to ignore materials that have the specular flag
set, but are missing a roughness texture.
Jak 2/3 now also support the `build-actor` tool.
The `build-custom-level` and `build-actor` macros now have a few new
options:
- Both now have a `force-run` option (`#f` by default) that, when set to
`#t`, will always run level/art group generation even if the output
files are up to date.
- `build-custom-level` has a `gen-fr3` option (`#t` by default) that,
when set to `#f`, will skip generating the FR3 file for the custom level
and only generate the GOAL level file to skip the potentially slow
process of finding and adding art groups and textures. Useful for when
you want to temporarily edit only the GOAL side of the level (such as
entity placement, etc.).
- `build-actor` has a `texture-bucket` option (default 0) which will
determine what DMA sink group the model will be placed in, which is
useful to determine the draw order of the model. Previously, this was
omitted, resulting in shadows not drawing over custom actors because the
actors were put in a bucket that is drawn after shadows (this behavior
can be restored with `:texture-bucket #f`).
2025-02-01 18:04:26 +01:00
23b86d95c3
CI: Periodic Controller Database Update ( #3847 )
...
Updating Controller Database
Co-authored-by: OpenGOALBot <OpenGOALBot@users.noreply.github.com >
2025-01-28 09:19:17 -05:00
7348e6a4ff
[decompiler] Update vector ops, reduce casts ( #3849 )
...
Update the decompiler to use the new vf macros.
Also, fix a bunch of silly casting issues where accessing inline fields
with an offset of 0 would be better than a cast:
---------
Co-authored-by: water111 <awaterford1111445@gmail.com >
2025-01-20 16:32:58 -05:00
98d6618a8b
[decompiler] Detect vector*! ( #3846 )
...
Detect use of `vector*!`, which is inlined in jak 2 and jak 3.
---------
Co-authored-by: water111 <awaterford1111445@gmail.com >
2025-01-20 12:21:28 -05:00
3ee2b4423c
[decompiler] Cleanup for Jak 3 ( #3845 )
...
This PR does a few cleanups:
- improve method names/comments/flags for `enemy.gc` and a few other
files
- fix `new-stack-matrix0` not working for jak 3
- add `matrix-copy!` detection for jak 3
- add `vector-copy!` detection
---------
Co-authored-by: water111 <awaterford1111445@gmail.com >
2025-01-20 10:31:29 -05:00
341f6117d5
Fix camera-other ( #3843 )
...
There's a feature to draw levels with a different camera matrix. This
uses `camera-temp-other`, `camera-rot-other`, etc instead of
`camera-temp`, `camera-rot`... I assumed that `trans-other` was the
"other" version of `trans`, but it turns out this isn't true -
`trans-other` is combined with `quat-other` and the original camera
matrix.
This fixes the issue by using the translation part of
`inv-camera-rot-other` for othercam levels only. (it works in all cases,
but I didn't want to use it for normal levels since I think it will be
less accurate)
Co-authored-by: water111 <awaterford1111445@gmail.com >
2025-01-18 17:44:38 -05:00
ee0600cdbf
[jak3] Improve overlord file size handling ( #3828 )
...
Try to avoid crashes/corruption if a file changes size after you've
started the game.
Co-authored-by: water111 <awaterford1111445@gmail.com >
2025-01-18 16:07:14 -05:00
a29fca982b
[jak1] Fix wind ( #3837 )
...
I accidentally broke this with the camera matrix improvements, but it's
fixed now.
---------
Co-authored-by: water111 <awaterford1111445@gmail.com >
2025-01-18 16:07:01 -05:00
9c9af5b488
CI: Periodic Controller Database Update ( #3839 )
...
Updating Controller Database
Co-authored-by: OpenGOALBot <OpenGOALBot@users.noreply.github.com >
2025-01-14 00:49:12 -05:00
f6fad0630f
macos: don't assume that all macOS major versions are simple numeric values ( #3836 )
...
Related to https://github.com/open-goal/launcher/pull/664
Likely Fixes https://github.com/open-goal/launcher/issues/663
2025-01-11 15:50:13 -05:00
434484e5b5
CI: Periodic Controller Database Update ( #3831 )
...
Updating Controller Database
Co-authored-by: OpenGOALBot <OpenGOALBot@users.noreply.github.com >
2025-01-11 12:16:14 -05:00
6f093f98ff
gsrc: Add convenience macros for masking VF operations ( #3824 )
...
Migrates all code, there should be no change in the compilation output
(linter should check this)
At first i was considering making these builtins, which short of a bunch
of code generation, would require some sort of dynamic definition in
`Atoms.cpp`. This isn't hard but, i figured it would be better to keep
it simple and just generate the OG macros.
Fixes https://github.com/open-goal/jak-project/issues/233
2025-01-11 12:16:05 -05:00
e836f09212
jak3: fix error with subtitle speaker names ( #3832 )
2025-01-07 11:33:05 +01:00
Tyler Wilding