* UNUSED attribute for variables and parameters in static segments and for all stack padding variables
* No more unused variable warnings
* Make pad variable names consistent
* Small cleanup
* Macro-ify stack padding
* Use stack padding for more variables not previously named pad
* Format
* Check unused parameter on gamestate overlays and pause menu
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
* Merge 2x u8 stack pads into 1x s16 stack pad in en_ik
* Remove UNUSED from function prototypes
* Suggested changes
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
* More unused variables
* Fix merge, updated for new versions
* Format
* questionable UNUSED and STACK_PAD more usage
* format
* format
* one more STACK_PADS in z_kaleido_map.c
---------
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
* rm PROJECT_DIR var from makefile
* fix tlutoffset missing 0x prefix
* fix FTOFIX32 redef warning
* `@bug:` -> `@bug`
* playerFloorPoly -> sPlayerFloorPoly
* fix settingChangeSuccessful use as bool
* fix broken english
* osEPiStartDma: use OS_MESG_PRI_HIGH
* EffectSsHahen_SpawnBurst: pass OBJECT_ for objId
* remove extra parens
* fix trailing comma warnings in enums
* EnRu1: decimal alpha
* fix parens
* fix ATELEM_SFX_NORMAL comment (collider "type" was renamed to material)
* fix comment in Math3D_TriChkPointParaYImpl
* use ANIMMODE_ more
* Remove leading 0s from enum comments (as they indicate octal in C)
Second pair of eyes for #2383: manually re-checked the extracted hanzi against the in-game message font glyphs and their message context. 8 entries were misread lookalikes; codepoints are unchanged so this only affects the human-readable labels, not the extracted bytes.
- ⋯ (U+22EF) → … (U+2026) @0xA109 — the font glyph matches the standard horizontal ellipsis
- 蠃 → 赢 @0xA12E — 000F "你贏啦！！" (bombchu bowling prize); 蠃 is a snail/clam, the glyph re-reads as 赢
- 噓 → 嘘 @0xA5DA — simplified form used throughout the simplified text
- 咩 → 哞 @0xA5F1 — message 2006, a cow talking about producing milk; 咩 is a sheep's bleat, 哞 a cow's moo (牛, not 羊, on the right)
- 亳 → 毫 @0xA605 — 201B "一根毫毛" (a single hair); 亳 is a place name, the glyph lacks its extra upper-right stroke
- 汊 → 汉 @0xA621 — 203F "懶漢" / 404E "男子漢" (lazy fellow / manly man); 汊 means a stream branch
- 鰓 → 鳃 @0xA68E — simplified form (fish gill)
- 寃 → 冤 @0xA75B — standard form (寃 is the variant spelling)
Apply the same replacements to CHN_CHARS in tools/extract_text.py (extraction charmap) so the build matches; charmap.chn.txt is used for building, CHN_CHARS for extraction.
* z_scene Some comments and function names
* review changes
* further fixing from comments
* vromAddr
---------
Co-authored-by: djevangelia <djevangelia>
* Document an includes style, apply to z_demo.c and z_play.c
* "reverse" style includes
* bss
* clarify what a "main header" is
* Update docs/includes.md
Co-authored-by: Tharo <tharo10600@gmail.com>
* Update docs/includes.md
---------
Co-authored-by: Tharo <tharo10600@gmail.com>
* [cc0 oot] Biri
* name biri anims (by usage, Z64Utils cant preview them)
* fixup bari/biri mixup
* EnBili cleanup
* biri cleanup
* biri: merge var ini with decl
* Document z_eff_ss_stone1.[ch]
* Incorporate feedback from PR review.
From https://github.com/zeldaret/oot/pull/2670:
- Shortened excessively verbose
suppressRTransFadeFlashAlphaStepAfterTwoFrames name to
suppressFadeFlash
- Fixed up comment that went waaaaaay beyond the column limit in
z_eff_ss_stone1.h
- Shortened comparison with 0 of variable bool semantics in
z_eff_ss_stone1.c
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
* Fix misnaming from PR review and document some more
From https://github.com/zeldaret/oot/pull/2670:
- shortenFadeFlash is incorrect - renamed to freezeFadeFlash
- Used `false` instead of 0 in EnArrow_Fly
- Elaborated comments about what exactly freezeFadeFlash does
Also added a few extra comments to z_eff_ss_stone1.c
* Ran clang-format
* More feedback from PR review, clarified comment
From https://github.com/zeldaret/oot/pull/2670:
- Change 0 to false in header comment
- Remove verbose speculation about former use of unused variable
- Made comment on use of viewDepth clearer
- Separated matrix and gfx code with a newline
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
* Marked the "1500" as being in units
---------
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
* spec: impl `include_once` and error on duped includes across spec
* duped includes fixups
* rm get_single_segment_by_name from spec.c (unused code)
* replace include logic with include_once's
* [rsp] Introduce microcode build process, disassemble and build both rspboot versions
* Suggested changes
* Check-in tool for generating armips.cpp from upstream sources, regen armips.cpp against a newer commit
* License armips_gen.py, add notice that armips.cpp is automatically generated
* Qualify comment with X105
* Clarify the assumed purpose of rspboot releasing SP_SEMAPHORE
* Automatically detect other common MIPS toolchains, update build dependencies in README
* Swap N64_GCCPREFIX and N64_INST for libdragon toolchain detection
Reonu