* Document z_eff_ss_stone1.[ch]
* Incorporate feedback from PR review.
From https://github.com/zeldaret/oot/pull/2670:
- Shortened excessively verbose
suppressRTransFadeFlashAlphaStepAfterTwoFrames name to
suppressFadeFlash
- Fixed up comment that went waaaaaay beyond the column limit in
z_eff_ss_stone1.h
- Shortened comparison with 0 of variable bool semantics in
z_eff_ss_stone1.c
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
* Fix misnaming from PR review and document some more
From https://github.com/zeldaret/oot/pull/2670:
- shortenFadeFlash is incorrect - renamed to freezeFadeFlash
- Used `false` instead of 0 in EnArrow_Fly
- Elaborated comments about what exactly freezeFadeFlash does
Also added a few extra comments to z_eff_ss_stone1.c
* Ran clang-format
* More feedback from PR review, clarified comment
From https://github.com/zeldaret/oot/pull/2670:
- Change 0 to false in header comment
- Remove verbose speculation about former use of unused variable
- Made comment on use of viewDepth clearer
- Separated matrix and gfx code with a newline
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
* Marked the "1500" as being in units
---------
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
* spec: impl `include_once` and error on duped includes across spec
* duped includes fixups
* rm get_single_segment_by_name from spec.c (unused code)
* replace include logic with include_once's
* [rsp] Introduce microcode build process, disassemble and build both rspboot versions
* Suggested changes
* Check-in tool for generating armips.cpp from upstream sources, regen armips.cpp against a newer commit
* License armips_gen.py, add notice that armips.cpp is automatically generated
* Qualify comment with X105
* Clarify the assumed purpose of rspboot releasing SP_SEMAPHORE
* Automatically detect other common MIPS toolchains, update build dependencies in README
* Swap N64_GCCPREFIX and N64_INST for libdragon toolchain detection
* BgSpot09Obj: document params type enum
* Address review comments
- Remove "objects" from description (has specific meaning in Zelda64 engine)
- Move BgSpot09ObjType enum to .h for use by external files
- Replace return 0/1 literals with false/true in func_808B1AE0
- Fix enum comments: remove "visible" terminology, correct tent is adult-only
---------
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
This is a tool introduced a long time ago that ended up not being
used at any point in the build system and has no prospects of
future use. There's no reason for keeping it around.
* Add all_versions_built dummy job for github status check
* the joys of gha, take 2
* the joys of gha, take 3
* ruin bss for testing
* the joys of gha, take 4
* refix bss
* Migrate CI to Github Actions (#2740)
Changes the CI system from Jenkins to Github Actions (GHA) as discussed on discord.
I tried to adapt the original jenkinsfile as I could.
One major difference from the old system is each version will now be built in parallel instead of sequentially.
Also, the mapfiles will be uploaded as an GHA artifact to the Action workflow. I think having them easily available would be nice.
This specific approach to handle GHA for decomp projects was adapted from the one used by the GC/Wii community. It is documented here https://github.com/encounter/dtk-template/blob/main/docs/github_actions.md
There's a writeup about this adaptation for N64 projects [here](https://github.com/AngheloAlf/drmario64/pull/19).
* Rename generate_patch_from_gha -> gha_fix_bss_and_generate_patch
* Make check formatting always on the full repo
* ruin z_fishing bss for CI testing purposes
* fix not passing VERSION to tools/gha_fix_bss_and_generate_patch.sh
* debugging gha_fix_bss_and_generate_patch.sh
* fix the debugging...
* git config safe.directory
* rm debugging stuff from gha_fix_bss_and_generate_patch.sh
* fix_bss gha-side machinery, attempt 1
* fix1
* fix2
* debug1
* checkout repo in merge_bss_fixes job
* fix3
* fix4
* fix5
* some prettify
* apply_fix_bss_patches.py complete
* fix6
* generate_patch.sh is back
* apply fix bss changes from gha! it works!
* generate_patch.sh suggestion
* ruin bss again for testing
* unruin bss
* Update .github/workflows/format.yml
Co-authored-by: Anghelo Carvajal <angheloalf95@gmail.com>
* update matrix version list
* finalize apply_fix_bss_patches.py
---------
Co-authored-by: Anghelo Carvajal <angheloalf95@gmail.com>
* Macro-ify access to pauseCtx->playerSegment regions.
Using macros to indicate which region in the player segment is being
accessed makes the memory layout more obvious and indicates the
intended level of memory ownership, particularly in the case of the
texture image at the start of the segment.
* Add clarifications for gameplay_keep details
* Uniform macro name for the render texture
* Comment
* Finish `EnExRuppy` documentation
* Rename throw distance field
* Move comments to enum type
* Use `EnHeishi1` type for guard
* Add comment on `EnHeishi1` supposition
Gabriel Ravier