Commit Graph

2500 Commits

Author SHA1 Message Date
Briggs Baltzell 4e66e63cd2 Rename fields in d_menu_cloth 2026-02-12 08:34:05 -06:00
Briggs Baltzell 7110e3be69 Refactor d_menu_cloth to replace repeated member accesses with HIO_CHILD macro for improved readability and maintainability. 2026-02-12 08:34:05 -06:00
Briggs Baltzell 67e6c789e1 Refactor dMCloth_c::plot to improve naming consistency for loop variables and pointer arithmetic. 2026-02-12 08:34:05 -06:00
Briggs Baltzell 4f11e02768 Refactor d_menu_cloth to improve pointer arithmetic in plot loop and add missing implementations for getOffsetVec and getShadowPos. 2026-02-12 08:34:05 -06:00
Briggs Baltzell 9b5f5956c5 Add member comments in dMenu_ClothMethodTable 2026-02-12 08:34:05 -06:00
Briggs Baltzell 1c3414fe92 Update d_menu_cloth to use msg_method_class and msg_process_profile_definition. Refactor structure definitions and add TODO comment for size clarification. 2026-02-12 08:34:05 -06:00
Briggs Baltzell 02dc9c0b68 Match dMCloth_c::plot_shadow implementation and update parameter names in plot and plot_shadow declarations. 2026-02-12 08:34:05 -06:00
Briggs Baltzell 3744bed5ed Match dMCloth_c::draw implementation, refactor initialization of field_0x10, and update associated structure definitions. 2026-02-12 08:34:05 -06:00
Briggs Baltzell 74d213afaf Refactor d_menu_cloth to replace s16 color fields with GXColorS10 and GXColor structures. Update all related logic and structure definitions accordingly. 2026-02-12 08:34:05 -06:00
Briggs Baltzell 4938076537 Match dMCloth_c::plot implementation and minor formatting fix in dMCloth_c::ShadowTevSettingMenu. 2026-02-12 08:34:05 -06:00
Briggs Baltzell eea0f2883e Match dMCloth_c::alpha_out implementation. 2026-02-12 08:34:04 -06:00
Briggs Baltzell a7ab1c9c9e Match dMCloth_c::ShadowTevSettingMenu and dMCloth_c::ShadowTevSettingFileSelect implementations. 2026-02-12 08:34:04 -06:00
Briggs Baltzell 2ba45aa4a0 Match dMCloth_c::ShadowTevSetting implementation. 2026-02-12 08:34:04 -06:00
Briggs Baltzell d1179371d1 Start matching dMCloth_c::cloth_move_sin and dMCloth_c::cloth_move_simple implementations. 2026-02-12 08:34:04 -06:00
Briggs Baltzell 332db836a4 Match dMCloth_c::cloth_move implementation and update type definitions for field_0xa and field_0x34 to s16. 2026-02-12 08:34:04 -06:00
Briggs Baltzell 4174c6decd Update g_fopAc_Method reference to g_fopMsg_Method in cloth menu structure. 2026-02-12 08:34:04 -06:00
Briggs Baltzell 8abcb6ee26 Match dMenu_ClothCreate, dMenu_ClothDelete, dMenu_ClothExecute, dMenu_ClothDraw, and dMenu_ClothIsDelete implementations and update related structure definitions. 2026-02-12 08:34:04 -06:00
Briggs Baltzell fc8aafe9b4 Match daCLOTH_HIO_c destructor implementation. 2026-02-12 08:34:04 -06:00
Briggs Baltzell 40a0c594d1 Match dMCloth_c::setNrmVtx implementation and update header declaration. 2026-02-12 08:34:04 -06:00
Briggs Baltzell 1cc8554cd8 Start matching dMCloth_c::cloth_init and update structure definitions to use INNER_SIZE constant, optimize initialization logic, and replace redundant assignments with consolidated methods. 2026-02-12 08:34:04 -06:00
Briggs Baltzell 4c2f8709a3 Match dMCloth_c::lightSet1 2026-02-12 08:34:04 -06:00
Briggs Baltzell 5dcf008f4b Match dMCloth_c::TevSettingMenu and dMCloth_c::TevSettingFileSelect. 2026-02-12 08:34:04 -06:00
Briggs Baltzell 8d74eb04dc Match dMCloth_c::TevSettingMenu 2026-02-12 08:34:04 -06:00
Briggs Baltzell 3aecfeb1ba Match dMCloth_c::TevSetting 2026-02-12 08:34:04 -06:00
Briggs Baltzell 63fb32f7ab Define ARR_SIZE constant and replace hardcoded array sizes in d_menu_cloth. 2026-02-12 08:34:04 -06:00
Briggs Baltzell 65e6b3a767 Refactor dMCloth_c to use mCurArr for indexing and update structure definitions in d_menu_cloth. 2026-02-12 08:34:03 -06:00
Briggs Baltzell b66d45b76e Match dMCloth_c destructor. 2026-02-12 08:34:03 -06:00
Briggs Baltzell 9d512edf7f Match dMCloth_c::init. 2026-02-12 08:34:03 -06:00
Briggs Baltzell bf6b491bd1 Match dMCloth_c::dMCloth_c 2026-02-12 08:34:03 -06:00
Briggs Baltzell f8a508ecf1 Remove unused member variables from daCLOTH_HIO_c and daCLOTH_ChildHIO_c in d_menu_cloth.h. 2026-02-12 08:34:03 -06:00
Briggs Baltzell 48e655a351 Initialize daCLOTH_HIO_c member variables and update daCLOTH_ChildHIO_c access modifiers in d_menu_cloth. 2026-02-12 08:34:03 -06:00
Briggs Baltzell cd41a8d961 Remove non-matching comments from daCLOTH_ChildHIO_c constructor and destructor in d_menu_cloth.cpp. 2026-02-12 08:34:03 -06:00
Briggs Baltzell 1f0fe4e0a6 Swap daCLOTH_HIO_c and daCLOTH_ChildHIO_c class definitions and adjust member variables in d_menu_cloth.h. 2026-02-12 08:34:03 -06:00
Briggs Baltzell 0925cf927e Add virtual destructor to daCLOTH_HIO_c in d_menu_cloth.h 2026-02-12 08:34:03 -06:00
Briggs Baltzell 6804012001 Add private member variables to daCLOTH_HIO_c in d_menu_cloth.h 2026-02-12 08:34:03 -06:00
Briggs Baltzell fedb963871 Include l_matDL in d_menu_cloth and call it in dMCloth_c::draw. 2026-02-12 08:34:03 -06:00
Briggs Baltzell 62bdc81d79 Initialize dMCloth_c member variables and create HIO child in constructor 2026-02-12 08:34:03 -06:00
Briggs Baltzell 454bf11f25 Refactor d_menu_cloth.h to improve naming consistency for member variables. 2026-02-12 08:34:02 -06:00
Briggs Baltzell fa29fb5394 Extend daCLOTH_HIO_c with JORReflexible and add static instance l_HIO in d_menu_cloth 2026-02-12 08:34:02 -06:00
Briggs Baltzell 610daa97cd Add l_matDL symbols and assets to config files for all regions for d_menu_cloth 2026-02-12 08:34:02 -06:00
Briggs Baltzell ca9481dcc9 d_cloth_packet matching (#928)
* Match dCloth_packet_c::setMtx

* Match dCloth_packet_c::setGlobalWind

* Match dCloth_packet_c::dCloth_packet_c constructor implementation

* Match dCloth_packet_c::getFactor and get_cloth_anim_sub_factor implementation

* Match dCloth_packet_c::cloth_move implementation

* Match dCloth_packet_c::setNrm implementation

* Match dCloth_packet_c::init and default_factor_checkCB implementation

* Match dCloth_packet_c::draw implementation

* Match dCloth_packet_c::cloth_draw implementation

* Match dCloth_packet_c::plot implementation

* Match dCloth_packet_c::TexObjLoad implementation

* Match dCloth_packet_c::TexObjInit implementation

* Match dCloth_packet_c::TevSetting implementation

* Match dCloth_packet_c::dCloth_packet_create implementation

* Match dCloth_packet_c::TevSetting implementation

* Match dCloth_packetXlu_c::TevSetting implementation and make dCloth_packet_c members protected

* Match dCloth_packetXlu_c::cloth_draw implementation

* Match dClothVobj03_c::cloth_copy implementation and update member definitions

* Match dClothVobj04_c, dClothVobj05_c, and dClothVobj07_0_c::cloth_copy implementations and update member definitions

* Match dClothVobj03_c::init implementation, update cloth_counter definitions, and add new member variables

* Match `dClothVobj04_c::init`, `dClothVobj05_c::init`, and `dClothVobj07_0_c::init` implementations, and add new member variables.

* Match `dClothVobj03_c::dClothVobj03_create` and constructor implementations, update member definitions, and add new logic checks.

* Match `dClothVobj03_c::cloth_move` implementation

* Match `dClothVobj04_c`, `dClothVobj05_c`, and `dClothVobj07_0_c::cloth_move` implementations

* Match `dClothVobj03_c`, `dClothVobj04_c`, `dClothVobj05_c`, and `dClothVobj07_0_c::TexObjInit` implementations, update member definitions, and initialize `mTlutObj`.

* Match `TexObjLoad` implementations for `dClothVobj03_c`, `dClothVobj04_c`, `dClothVobj05_c`, and `dClothVobj07_0_c`.

* Fix `dClothVobj04_c::cloth_move`

* Match `dClothVobj04_create`, `dClothVobj05_create`, and `dClothVobj07_0_create` implementations, update parameter definitions, and add new constructor logic.

* Update parameter names in `dClothVobj05_VtxFactorCB` and `dClothVobj07_0_VtxFactorCB` for consistency.

* Adjust parameter values in `dClothVobj05_create` and `dClothVobj07_0_create` for consistency with expected behavior.

* Match `dClothVobj05_VtxFactorCB` and `dClothVobj07_0_VtxFactorCB` implementations and update return logic.

* Fix constructors

* Refactor repetitive parameter assignments in `dCloth_packet_c` with `setParam` and `setWindPower` for cleaner and more maintainable code.

* Add `setFactorCheckCB` call in `dCloth_packet_c` initialization

* Refactor `dCloth_packet_c` and related classes to eliminate redundant success checks with `chkCreateBuff` helper method.

* Refactor `dCloth_packet_c` and related classes to use getter methods for cleaner access and rename methods for improved clarity.

* Simplify constructors for `dClothVobj03_c`, `dClothVobj04_c`, `dClothVobj05_c`, and `dClothVobj07_0_c` by removing redundant parameters.

* Replace `field_0x109` with `mIsIndoors` for improved clarity and consistency across `dCloth_packet_c` and related classes.

* Replace `VECDotProduct` with `inprod` method in `dCloth_packet_c` for improved readability and modern syntax usage.

* Make `top_pointer` and `cloth_counter` members private in multiple `dClothVobjXX_c` classes for encapsulation.

* Match cloth creation functions

* Add `l_alpha_matDL` assets and update `GXCallDisplayList` usage in `dCloth_packetXlu_c`

* Match dCloth_packet_c::init

* Match dCloth_packet_c::setNrm

* Refactor dCloth_packet_c to use mDoMtx_stack_c methods

* Match `get_cloth_anim_sub_factor` implementation in `dCloth_packet_c`.

* Refactor `getFactor` in `dCloth_packet_c` to use a bitmask for neighbor checks, enhancing code clarity and efficiency.

* Match dCloth_packet_c::cloth_move

* Match dCloth_packet_c::setGlobalWind

* Match dCloth_packet_c::plot implementation

* Remove unused virtual function declarations

* Update `d/d_cloth_packet.cpp` to Matching in configure.py

* Refactor field_0x108 and mIsIndoors to boolean types, rename, and add explanatory comments.

* Update `d/d_cloth_packet.cpp` to `MatchingFor("GZLE01")` in configure.py

* Add new material and alpha material configurations for `d_cloth_packet` across GZLP01, GZLJ01, and D44J01

* Update `d/d_cloth_packet.cpp` to `Matching` in configure.py

* Update `d/d_cloth_packet.cpp` to `MatchingFor("GZLE01", "GZLP01")` in configure.py

* Add conditional GXSetNumIndStages and resetVcdVatCache for non-JPN versions in `dCloth_packet_c::draw`

* Update `d/d_cloth_packet.cpp` to `MatchingFor("GZLJ01", "GZLE01", "GZLP01")` in configure.py

* Matched dCloth_packet_c::dCloth_packet_c for `VERSION_DEMO` in `d/d_cloth_packet.cpp`

* Matched dCloth_packet_c::cloth_move for `VERSION_DEMO` in `d/d_cloth_packet.cpp`

* Matched dCloth_packet_c::draw for `VERSION_DEMO` in `d/d_cloth_packet.cpp`

* Matched dCloth_packet_c::TexObjInit for `VERSION_DEMO` in `d/d_cloth_packet.cpp`

* Matched dClothVobjXX_c::TexObjInit for `VERSION_DEMO` in `d/d_cloth_packet.cpp`

* Update `d/d_cloth_packet.cpp` to `Matching` in configure.py

* Replaced direct member access with getter methods in `d/d_cloth_packet.cpp`

* Added `f` suffix to floating-point literals in `d/d_cloth_packet.cpp` for consistency.
2026-02-12 01:42:21 -05:00
ssorenson130 579931b72c d_a_obj_volcano matching (#924)
* start

* startfire

* some partial matches

* matching

* cleanup

* demo matching
2026-02-11 22:45:53 -05:00
Roland 2168699559 d_a_npc_rsh1 matching (#927)
* Initial work

* 14% matching in .text
- Add some of the static data
- Match sinit function
- Match HIO constructor
- Match _create
- Match some other trivial functions

* Match CreateHeap

* 20% matching in .text

* 31% matching in .text

* 34% matching in .text

* 38% matching in .text

* 51% matching in .text

* createShopList work

* More createShopList work

* 54% matching in .text: Match createShopList

* 57% matching in .text

* 68% matching in .text

* Variable name updates

* 75% matching in .text

* 81% matching in .text

* Match lookBack

* d_a_npc_rsh1 100% for demo and retail

* Replace magic constants with applicable enums

* Give some member fields trivial names and name some method parameters

* Fix a few renaming errors

* More renaming work

* Rename HIO fields and rest of actor fields

* Replace magic numbers associated with mItemNo
2026-02-11 22:40:15 -05:00
Roland c79fa65efd d_a_npc_ls1 matching (#925)
* Match daNpc_Ls1_c::create, decideType, and ctor

* 16% matching in .text
-Match daNpc_Ls1_c::CreateHeap
-Match daNpc_Ls1_c::itemCreateHeap
-Match daNpc_Ls1_c::handCreateHeap
-Match daNpc_Ls1_c::_delete
-Match other trivial functions

* Add hio_prm_c

* 27% matching in .text
-Add some static data
-Match daNpc_Ls1_c::endEvent
-Match daNpc_Ls1_c::isEventEntry
-Match daNpc_Ls1_c::execute
-Match daNpc_Ls1_c::bodyCreateHeap
-Match some more trivial funcs

* 33% matching in .text
-Match daNpc_Ls1_c::create_init
-Match daNpc_Ls1_c::chngAnmTag
-Match daNpc_Ls1_c::ctrlAnmTag
-Match init_LS1_#n() funcs
-Match searchActor funcs

* Add daNpc_Ls1_c::anm_prm_c struct and associated static data

* 39% matching in .text
- Matched daNpc_Ls1_matAnm_c::calc
- Matched static node callbacks
- Matched daNpc_Ls1_c::setAnm_anm
- Matched daNpc_Ls1_c::setAnm_NUM
- Matched daNpc_Ls1_c::chngAnmAtr
- Misc code formatting changes

* 52% matching in .text
- Match daNpc_Ls1_c::play_animation
- Match daNpc_Ls1_c::set_mtx
- Match ResID funcs
- Match daNpc_Ls1_c::setBtp
- Match daNpc_Ls1_c::setMat
- Match daNpc_Ls1_c::setBtk
- Match daNpc_Ls1_c::init_texPttrnAnm
- Match daNpc_Ls1_c::play_btp_anm
- Match daNpc_Ls1_c::play_btk_anm
- Match daNpc_Ls1_c::ctrlAnmAtr
- Match daNpc_Ls1_c::setAnm_ATR
- Match daNpc_Ls1_c::chk_parts_notMov
- Match daNpc_Ls1_c::cut_init_LOK_PLYER
- Match daNpc_Ls1_c::cut_move_WAI
- Match daNpc_Ls1_c::cut_init_ANM_CHG
- Match daNpc_Ls1_c::set_action

* Update comments

* Match daNpc_Ls1_c::_draw

* 63% matching in .text
- Match member J3D node callbacks
- Match daNpc_Ls1_c::eye_ctrl
- Match daNpc_Ls1_c::next_msgStatus
- Match daNpc_Ls1_c::getMsg
- Match daNpc_Ls1_c::chk_talk
- Match daNpc_Ls1_c::setEyeCtrl
- Match daNpc_Ls1_c::clrEyeCtrl
- Match daNpc_Ls1_c::setAttention
- Add misc enums
- Add a_cut_tbl

* 66% matching in .text
- Matched daNpc_Ls1_c::searchByID
- Matched daNpc_Ls1_c::partner_search_sub
- Matched daNpc_Ls1_c::partner_search
- Matched daNpc_Ls1_c::chkAttention
- Marched daNpc_Ls1_c::shadowDraw

* 75% matching in .text
- Match daNpc_Ls1_c::anmAtr
- Match daNpc_Ls1_c::getMsg_LS1_0
- Match daNpc_Ls1_c::chk_talk
- Match daNpc_Ls1_c::setStt
- Match daNpc_Ls1_c::get_playerEvnPos
- Match daNpc_Ls1_c::chkTelescope
- Match daNpc_Ls1_c::wait_1
- Match daNpc_Ls1_c::wait_4
- Match daNpc_Ls1_c::talk_1
- Match daNpc_Ls1_c::demo_action1

* Match daNpc_Ls1_c::wait_3

* 100% matching for both demo and retail

* Update comments

* Initial refactoring work

* Renaming work & declaring functions in f_op_msg_mng header

* Refactoring continued

* Last bit of renaming work

* Add missing include
2026-02-11 22:31:05 -05:00
Roland 1763262970 d_a_oship matching (#929)
* Initial work, 30% matching in .text

* 42% matching in .text

* 51% matching in .text

* 72% matching in .text

* 75% matching in .text

* 93% matching in .text

* d_a_oship 100% for both demo and retail
2026-02-11 22:24:08 -05:00
LagoLunatic e28808ad39 Fix tww_class_to_cpp not working for pyghidra 2026-01-23 21:44:10 -05:00
Mike Lester 9cc61c4058 Fix up a shadow-related variable/parameter names (#920)
* Fix up a shadow-related variable/parameter names

* Fix compilation errors in d_a_obj_barrel.cpp
2026-01-13 01:01:35 -05:00
Roland ba4a7b481c d_a_obj_buoyrace - matching (#921)
* 13% matching in .text

* 32% matching in .text

* d_a_obj_buoyrace 98%

* d_a_obj_buoyrace demo 98%

* link d_a_obj_buoyrace

* Small refactor

* More refactoring

* Small renaming work

* Fix errors

* Variable name cleanup
2026-01-12 14:17:01 -05:00
Roland 6893c2588e d_a_goal_flag - matching (#918)
* initial work on d_a_goal_flag

* Update config.yml to extract symbols from d_a_goal_flag; also add l_pos and l_texCoord

* 17% matching in .text

* daGoal_Flag_c::CreateHeap matched

* RopeMove 99%

* Update d_a_goal_flag.cpp

* getRacePath 100%

* 31% in .text

* 47% matching in .text

* 56% matching in .text

* 70% matching in .text
Add definitions to inlines in daGFlag_packet_c and fully matched some daGFlag_packet_c methods.

* 84% matching in .text
Match daGFlag_packet_c::draw

* 91% matching in .text
- Formatting tweaks
- Match TimerExecute
- Add fopMsgM_MiniGameTerminater_create inline
- Move daGoal_Flag_c::_create in the correct place to match .data

* d_a_goal_flag matching 100% for retail

* d_a_goal_flag demo 99%

* Resolve _create fakematch

* d_a_goal_flag demo matching 100%

* link d_a_goal_flag for demo

* Renaming of fields/variables and some refactoring

* Refactoring continued
- Change direct calls to VECDotProduct to cXyz::getDotProduct

* Named more HIO fields and packet fields

* Implement fopMsgM_MiniGameStarter_create

* Name all used HIO fields

* Named all fields in daGoal_Flag_c

* Finishing touches
2026-01-09 13:09:23 -05:00
Lord-McSweeney ca83b5d1ae d_file_error matching (#915)
* d_file_error decompiled

* Use dComIfGs_getPalLanguage

* Resolve review comments

* d_file_error matching for non-debug
2026-01-01 14:14:13 -05:00