* d_a_leaflift 100%
* d_a_leaflift_static 100%
Additional formatting changes plus variable re-naming's due to added context from `d_a_leaflift_static`
* PR changes made, renamed other variables
The m43C-m43E flags seem to be flags relating to Link's gliding state but couldn't figure out the order of them. m43F seems to be some timer.
* additional PR changes
* d_a_shutter_2 100%
- Code should be consistent with `d_a_shutter`
- A couple of variables still remain unnamed
* fixed issue in configure.py, git related
* forgot to set to matching
* weak function ordering in fine, removed param
* merged decleration and instantiation of minVel, maxVel
* PR changes
_create() still has me stumped. You would think that the return after that if statement would be `return cPhs_COMPLEATE_e;` but it just, doesn't exist? Adding any sort of return statement causes it not to match. Potential bug forgotten by the devs maybe?
* d_a_shutter 100%
- Wasn't sure what to name some of the used member variables that have yet to be assigned names (ex. `field_0x339`) but if you have an intuitive guess based on the code/previous actors I'd be happy to change them
* Requested PR changes made
The only thing I was unsure about was the new name for `mCount`. I settled on `mFrameTimer` because it's initialized to 30 and counts down every frame (assuming `_execute()` is called every frame).
* changed typing of `mbIsSwitch` to remove unnecessary cast
* file reference changes
* d_a_steam_tag 100%
Added inline functions to `d_point_wind` that were referenced in this TU
* PR changes added
- Also removed an unused local variable, renamed another
- Seems my struct had one member too many so I removed the last one ('field_0x0F`) and resized `field_0x0E` accordingly
* d_a_tori_flag 100%
Had to add a constructor for `dCloth_packet_c`, may want to reconsider the naming of certain members of `daTori_Flag_HIO_c` in the future.
* d_a_tori_flag 100% configuration
* Requested PR changes made
* added proper inline functions
It's not completely consistent, but it seems like the majority used `bool`, and only a handful used `BOOL`. So I switched all of them to `bool` except for 13 TUs that stopped matching when changed like this.
* daObjHhaPart_c : progress on init_data, set_mdl_area, set_bgw, init_mtx
* daObjHhaSplash_c::create_s match
* daObjHhaYgush_c::create_area match
* daObjHhaYgush_c::init_data match
* daObjHhaYgush_c::init_mtx match
* daObjHhaYgush_c::draw match
* daObjHha_c class definition
* exe_normal & draw_normal match
* daObjHha_c::create_heap match
* daObjHha_c::_create match
* daObjHha_c::_delete almost match
* daObjHha_c::check_sw
* daObjHha_c::set_tex match
* daObjHha_c::init_mtx match
* daObjHha_c::get_water_h
* daObjHha_c::set_splash_bottom_* & daObjHha_get_r match
* daObjHha_c::set_splash_bottom_stop_r match
* daObjHha_c::part_manager almost match
* daObjHha_c::ygush_manager match
* daObjHha_c::_execute almost match
* daObjHha_c::_draw match
* daObjHha_c::water_manager match
* Mthd match
* da_a_obj_hha object file match
* Cleaning & adding variable names
* Updating configure.py & cleaning
* fixing d_a_obj_hha constants symbol name
* Adding suggestions (zeldaret/tww/#688)
* Fixing d_a_obj_hha Mthd (as suggested in PR zeldaret/tww/#688)
* Reverting configure.py
* d_wood (bushes) 73% matching
* d_wood::Unit_c::set_ground 100% match
Jasper pointed me to the fact that the complicated inv_sqrt function I wrote was indeed just std::sqrtf(), which unlocked the rest of the match
* Replace some bitshifts with multiplies based on PR feedback
* Remove all instances of "this->" from d_wood
* Add missing struct offset comment for mTevStr
* Cleaned up d_tree externs
* Use MTXIdentity instead of PSMTXIdentity
* Remove incorrect TODO rearding cCcD_ObjAtType enum
* Use the mDoAud_seStart inline function
* Remove unnecessary parenthesis
* Fix incorrect branching logic in d_wood::cc_hit_before_cut()
* d_wood data sections fixup
* Re-add "Nonmatching" comments to all nonmatching functions
* Formatting: reformat from 2 to 4 space indentation
This was a local system problem which slipped by me in a previous commit
* 100% match for d_wood::Anm_c::mode_norm()
Thanks Chippy! https://discord.com/channels/727908905392275526/873250400483024976/1298360716964790294
* Use cLib_*Bit() functions for flag checking and setting
Based on the inline functions from the .map
* d_wood: Use AnmID_e according to the .map file
* d_wood: add a couple AnmID_e related inlines from the .map
* d_wood: Name remaining unknowns related to animation
* d_wood: Match cc_hit_before_cut()
* d_wood: Match calc_cc() by using the dComIfGp_roomControl_getStayNo() inline
* d_wood: Match string table and search_anm() by using a constant in assert string
* d_wood: Match mode_to_norm()
Switching normAnim to a const* did most of the work
* d_wood: 100% match for L_attr and the .rodata section
* d_wood: Fill in .data section. Still some extra data from vtables
* d_wood: Match .sbss section
* d_wood: Match .sdata section
* d_wood: 98% match for Packet_c::draw()
The only error is that g_dTree_shadowTexCoord is still using a 32-bit load instead of 16. the only way I know of to fix that is to define the data in this compilation unit. But that can't be right
* d_wood: Various small formatting changes
- No one line function implementations
- Replaced instances of (SomeType*)0x0 (copy/pasted from Ghidra) with NULL
- Replaced a few instances of 0.0 with 0.0f
- Replaced one instance where a number was used instead of an enum value
* d_wood: More formatting fixes
- Removed unused variables from functions
- Removed unnecessary iVar1 loop variables (leftover Ghidra detritus)
- Fixed dtk function comments being wrapped by autoformatter. They now always appear on one line
* d_tree: 100% match of data which is used by d_wood
This moves g_dTree_shadowTexCoord into .sdata which allows d_wood::Packet_c::draw() to load its address with a single instruction. This makes a 100% match for draw()
* d_wood: Removed unnecessary comment now that draw() matches
g_dTree_shadowTexCoord now lives in the d_tree .sdata section, so its instruction can be loaded with a single instruction. This makes a 100% match with draw().
* d_wood: 100% match for mode_cut()
* d_wood: Match mode_push_into()
Also renamed mWindDir to mForceDir as it represents both wind and an actor pushing from a vector
* d_wood: Match mode_push_back
* d_wood: Match __sinit_d_wood_cpp
The l_matDL display list is dynamically patched to reference the l_Txa_swood_bTEX texture at static initialization time. Is there a better way to represent this?
* d_wood: Fix incorrect constant in set_ground()
* d_wood: Simplify dummy data at the top of .data section
* d_wood: Mark as matching in configure.py
Had to move Packet_c destructor to get the functions in the right order. See discussion: https://discord.com/channels/727908905392275526/873250400483024976/1300680009458913280
* d_wood: Add `d/d_cc_d.h` include as some enums have moved
* d_wood: Clean up some types at the top
* Mark d_wood as non-matching for the Japanese version
Nikolaj Jensen Ulrik