Commit Graph

16 Commits

Author SHA1 Message Date
WilliamArnett 11f4940d74 d_a_npc_p1 100% Matching (#1098)
* 99% match

* Rewrote _execute to increase accuracy. Only issue in .text is a label not loading correctly. I have no idea how to fix this.

* Equivalent. Weak func ordering.

* 7% text

* 28% text

* 41% text

* 65% text

* Rewrote _execute to increase accuracy. Only issue in .text is a label not loading correctly. I have no idea how to fix this.

* Equivalent. Weak func ordering.

* 82% text

* Equivalent. A lot of work is needed to name variables and clean up functions. Weak function ordering is wrong.

* Cleaned some functions, named several variables, and began documenting dialog tree.

* Naming a couple more variables

* 21% text

* change out getMySubstanceP for getMyIntegerP inline

* 100% text

* Refactor to use JUT_ASSERT macro

* #181: d_a_tag_attention matching; TODO: implement chk_inside and dComIfGp_att_Look2RequestF

* #181: continue working on d_a_tag_attention, matching almost complete

* #181: revert naming class member (not certain enough)

* #181: preliminary changes to resolve #784 comments regarding usage of debug maps

* #181: commit suggestion by @WilliamArnett, fixing regalloc error

Co-authored-by: WilliamArnett <149556961+WilliamArnett@users.noreply.github.com>

* #181: fix missing curly bracket

* #181: resolve #784 comments with the kind help of @WilliamArnett;
 move `daTagAttention::Act_c::chk_inside` to header file; split `plyrToObjVec` definition to match assembly;
 remove temp variable, use values directly and swap operands;
 implement `Look2RequestF` in `include/d/d_attention.h`;
 remove non-matching use of temp variable `iVar1` and replace `current.pos` with uninitialized variable in `daTagAttention::Act_c::_execute`

* Update fork to match upstream

* some changes

* 73% text

* 100% Matching minus kaji_anm

* Delete debug/m2cdecomp

* revert unnecessary file changes

* remove d_a_npc_p2_cut.inc

* Match kaji_anm

* swap declaration order of l_msg and l_msgId

* Naming many fields

* Implement GetKajiID inline

* Enum and variable names

* Remove virtual genMessage function

* Implement @LagoLunatic 's suggested changes

* Revert array changes in d_camera.h (@LagoLunatic suggested change)

* Whitespace

* Rename dSnap enum

---------

Co-authored-by: Skelp <skelp@pm.me>
Co-authored-by: Skelp <59535863+Skelp@users.noreply.github.com>
2026-08-03 01:40:12 -04:00
LagoLunatic db3753b3c9 Fix weak func order for ykgr, obj_pirateship, obj_barrier, npc_photo 2025-08-21 23:36:47 -04:00
LagoLunatic ac8ff10650 Fix most weak function ordering issues 2025-08-20 19:09:06 -04:00
Maide 78e0524995 d_a_obj_pirateship (#836) 2025-08-07 13:48:26 -04:00
LagoLunatic e71662caa0 More return types, set up all dBgS_MoveBgActor subclasses 2025-03-18 16:17:53 -04:00
LagoLunatic 822b13e57a Add cPhs_State typedef and use it everywhere 2025-03-17 22:26:56 -04:00
LagoLunatic 025b7e459a Switch return type of _execute/_draw/_delete to be bool by default instead of BOOL
It's not completely consistent, but it seems like the majority used `bool`, and only a handful used `BOOL`. So I switched all of them to `bool` except for 13 TUs that stopped matching when changed like this.
2025-02-01 16:17:46 -05:00
LagoLunatic 3b40fd0132 Add back unnamed namespace methods, all actors now compile again 2024-04-22 17:51:41 -04:00
LagoLunatic ad4d58bab8 d_a_sail start 2024-04-15 22:53:19 -04:00
LagoLunatic 133df570d9 d_com_static OK 2024-04-13 15:16:15 -04:00
LagoLunatic 96513abb0a various fixes to get more actors to compile 2023-12-30 18:59:57 -05:00
LagoLunatic 8a2bc19a89 Better defaults for create/delete/execute/draw/isdelete 2023-11-24 16:49:23 -05:00
LagoLunatic 6c9b6c3c00 Manually fix headers for build 2023-11-24 13:06:40 -05:00
LagoLunatic 471b881de8 Automatically generate headers for all actors 2023-11-24 12:44:06 -05:00
LagoLunatic 61d2e5a17e Started d_com_static 2023-10-29 22:43:31 -04:00
LagoLunatic 5fb89c15d8 d_a_kaji OK (#35)
* d_a_kaji OK

* Fix return types

* Whoops, wrong bool for one
2023-09-15 00:23:23 -04:00