`install` builds ALL, which never included GenerateSohOtr, so it copied
whatever soh.o2r was already in the build tree. The version check can't
catch that: a stale soh.o2r carries the same version as the binary.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
GCC 15's libstdc++ defines feature-test macros selectively: after
#include <string>, __cpp_lib_source_location is not yet defined, even
though __builtin_source_location is fully supported. This made the
check fail on GCC 15 toolchains (including clang using libstdc++),
disabling the Hook Debugger.
Include <version> first so all feature-test macros are defined.
The SAPI and AVSpeechSynthesizer backends both drop what they are saying when
a new utterance arrives (SPF_PURGEBEFORESPEAK, stopSpeakingAtBoundary). espeak
never did, so on Linux every menu item scrolled past queued another utterance
with no way to skip ahead.
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
1. clicking on flag name toggles checkbox
2. hovering over player state shows flag name
3. add search box for player state, adjust names to what headers call them
Rename All Locations Reachable to All Checks Reachable.
Rename Locations section to Check Locations.
Properly fix checkbox/radio button label wrapping.
GameInteractor.h does not itself depend on libultraship/bridge/consolevariablebridge.h,
instead its dependencies requiring that header should include it themselves
This was particularly impactful for SohGui.hpp which included all the windows
This aims to port over the Time Splits feature from 2Ship as it is cleaner & more robust.
New to this is the ability to finally compare splits from a second list.
Old Save data will now be converted to the new format automatically. Once it converts the data, the old save file will be renamed with a new ".backup" extension.
Co-authored-by: serprex <159546+serprex@users.noreply.github.com>
The hotkey was removed in #2833 because Linux had no synthesizer and fell
through to SpeechLogger. #5428 added the espeak-ng backend and un-gated the
settings checkbox, but left the hotkey and the README on Windows and macOS.
No need to 4x color, just use what player picks. Avoid stale reads by getting rid of currentColor
Also clean up MIN/MAX & tidy up randomizer.h including CustomMessageTypes.h
* Don't erase __attribute__ under clang-cl
The shim fires when __GNUC__ is absent, which clang-cl does not define even
though it supports __attribute__ fully. Erasing it breaks clang's own intrinsics
headers: mmintrin.h declares __m64 as a vector via __attribute__((vector_size)),
so it degrades to a scalar and every use of it fails to compile.
* Don't erase __attribute__ under clang-cl
clang-cl supports it but does not define __GNUC__, so the shim fired and broke
clang's own intrinsics headers.
soh/CMakeLists.txt empties CMAKE_CXX_FLAGS_RELEASE under MSVC, and the 64-bit
branch adds /Oi and /Gy but no optimisation level, so the target is built /Od.
The Win32 branch below it already passes /O2.
The MSVC block drops CMake's defaults wholesale, and /EHsc goes with them, so
Windows builds compile every try/catch without unwind semantics - cl only warns
(C4530). soh and libultraship have 25 of them between them, including the
config and archive paths in OTRGlobals, where a throw would skip destructors.
clang-cl refuses outright rather than warning, which is how this surfaced.
C-button loop should not read D-pad,
D-pad keys off index like SyncButtonItemsForSlot,
B-button skips, ITEM_NONE while swordless would every empty slot green
Philip Dubé