Commit Graph

1947 Commits

Author SHA1 Message Date
Dragorn421 253eec1fdc [assets] Add most missing TLUTOffsets (#1890)
* [assets] Add TlutOffset to CI textures: misc, gkeeps, `object_[ab]*`

* [assets] Add TlutOffset to CI textures: `object_[c-i]*`

* remove extra space before TlutOffset

* [assets] Add TlutOffset to CI textures: `object_[j-n]*`

* [assets] Add TlutOffset to CI textures: `object_[o-z]*`

---------

Co-authored-by: Anghelo Carvajal <angheloalf95@gmail.com>
2026-08-13 18:40:56 -04:00
Dragorn421 e77acba9c4 [GHA] Fixup final jobs if conditions (#1889) 2026-08-13 18:26:32 -04:00
Dragorn421 8e58eea667 [assets] xml fixups (#1888) 2026-08-12 18:34:26 -04:00
Anghelo Carvajal b9861edd77 Migrate CI to Github Actions (#1885)
* Migrate CI to Github Actions (#1884)

Changes the CI system from Jenkins to Github Actions (GHA) like we did for OoT

This is an adaptation of the Jenkinsfile we have and the solution made by @Dragorn421 for OoT

Relevant OoT PRs:
- https://github.com/zeldaret/oot/pull/2740
- https://github.com/zeldaret/oot/pull/2742
- https://github.com/zeldaret/oot/pull/2754

New features include:
- Not needing to selfhost a runner
  - Required private stuff for building is hosted on a private repo
- Building multiple versions in parallel
  - Our old jenkinsfile wasn't building `n64-jp-1.1`. Even if it doesn't match right now, I think it is important checking a PR doesn't completely break it.
- Run bss fixer in CI
- Upload mapfiles as build artifacts

This specific approach to handle GHA for decomp projects was adapted from the one used by the GC/Wii community. It is documented here https://github.com/encounter/dtk-template/blob/main/docs/github_actions.md There's a writeup about this adaptation for N64 projects [here](https://github.com/AngheloAlf/drmario64/pull/19).

* Remove duplicated step id

* Wire up compiler_archives machinery

* Remove extra quote

* Select bash as the default shell

* Fix asset extraction for WIP versions

* Properly fix the assets step this time

* fix assets building for jp

* Prevent running CI on forks

Incorporates the changes from https://github.com/zeldaret/oot/pull/2788

* Incorporate fix_bss tiebreaking algorithm from https://github.com/zeldaret/oot/pull/2779
2026-08-04 18:14:57 -04:00
Jordan Longstaff a6850d2149 Document a few symbols regarding the Ikana Canyon guard (#1868)
* Document a few symbols regarding the Ikana Canyon guard

* Use switch-case in lieu of temp

* Reformat switch-case

* Re-format switch-case, fix braces
2026-07-19 07:59:01 -07:00
Jordan Longstaff 5fd95d51f9 Document EnTest3 (#1881)
* Document `EnTest3`

* Add comments for enum-type fields

* Add scheduled action index comments

Co-authored-by: Copilot <copilot@github.com>

* Use enums in comparisons

* Rename `sp3C`

* Rewrite comments on speak data

Co-authored-by: Copilot <copilot@github.com>

* Reformat

* Missed a text comment

* Missed another text comment

---------

Co-authored-by: Copilot <copilot@github.com>
2026-07-18 12:20:31 -07:00
Jordan Longstaff ae6e93fcf9 Document BgIknvDoukutu (#1867) 2026-07-18 11:25:26 -07:00
Jordan Longstaff 29425bb7cf Bombers Part 3: EnBombers (#1849)
* Bombers Part 3: Wandering NPCs and caught players

* Rename WEEKEVENTREG flags

* Fix missing rename of `unk_2A0`
2026-07-18 10:52:47 -07:00
Derek Hensley f1a423cdcd [n64-jp-1.1] audio_thread_manager (#1880) 2026-05-27 07:33:10 -07:00
Jordan Longstaff 49cd9aeb99 Document ObjWturn (#1866) 2026-04-28 08:38:43 -04:00
Derek Hensley b2c66163c7 [n64-jp-1.1] idle (#1875) 2026-04-28 08:21:02 -04:00
Derek Hensley 6c2e0113f8 [n64-jp-1.1] libu64/debug (#1873) 2026-04-26 10:55:04 -04:00
Derek Hensley 1ba2815d09 [n64-jp-1.1] z_std_dma (#1879) 2026-04-26 10:47:19 -04:00
Jordan Longstaff 354a8637e1 Bombers Part 2: Guard (#1848)
* Bombers Part 2: Guard

* Fix errors

* Re-rename functions
2026-04-26 09:59:30 -04:00
Derek Hensley 57e41795f5 String macros (#1871)
* PRINTF

* T

* fault

* yaz0

* __osMalloc

* audio_thread_manager

* graph

* padmgr

* sched

* z_play

* z_arrow_ice

* z_arrow_light

* z_elf_msg

* z_elf_msg3

* z_elf_msg4

* z_elf_msg5

* z_mir_ray

* stackcheck

* Include versions in macros.h

* Fix workaround for permuter
2026-04-21 08:12:46 -04:00
Anghelo Carvajal fa85e7cda5 [n64-jp-1.1] __osMalloc.c matched (#1845)
* match osmalloc

* some names

* format

* Breakup osFree checks and move strings around

* misc changes
2026-04-20 10:32:24 -07:00
Isghj ffc67c3e0a EnPr2 Skullfish documented (#1830)
* Pr2: some docs, first struct pass

* Pr2: Most functions named

* Pr2: more docs

* Pr2: object documented

* Pr2: object documented

* Pr2: format

* Pr2: more docs, format

* Pr2: requested changes

* Pr2: requested changes

* Pr2: forgot prz used the object too

* Pr2: more skelton limb enum changes

* Pr2: removed old comment
2026-04-19 09:35:39 -07:00
Jordan Longstaff 9eb9f6f978 Document WEEKEVENTREG enabling peephole in Curiosity Shop (#1870) 2026-04-17 07:26:40 -04:00
Dragorn421 6eb574fff7 Use <Limb LimbType=> not <Limb Type=> in gkeep and object_link_child (#1859) 2026-04-09 08:42:58 -04:00
Jordan Longstaff 215f01d670 Document BgAstrBombwall (#1865) 2026-04-09 07:47:28 -04:00
Jordan Longstaff 33f8d3c62b Document EnKendoJs (#1838)
* Document `EnKendoJs`

* Fix typedefs

* Fix isSlashingLog reference

* Found out what that unused animation was

* Rename animation constants

* Rename WEEKEVENTREG flag

* Remove trailing whitespaces

* Fix uses of isSlashingLog

* Rename Skel object

* Deciphered FF part of params

* Dismantle message enum

* Remove mask message macro

* Refactor message start macro

* Rename text ID arrays

* Use boolean values for isRetracting

* Remove statement added by faulty merge

* Rename message handler functions

* Minigame round union for clarity
2026-04-08 07:34:59 -04:00
Tharo 2121d62a6f Audio: Fix note values (#1864)
Due to the layout of the pitch_frequencies lookup table, note values
computed in extraction were reflected around middle C (midi note
number 60). This didn't matter for matching, values would successfully
roundtrip. However when using samples in external programs or
converting soundfonts to standard formats the note values would lead
to incorrect playback of sounds. This change corrects the note values
so that external programs correctly infer the pitch of the sound when
played at a particular MIDI key.
2026-03-28 18:01:53 -03:00
Anghelo Carvajal a9da608e18 [n64-jp-1.1] CIC6105.c matched (#1843)
* match CIC6105.c

* Renames and fixes

* Fix bss

* format

* Review

* Version check inequalities
2026-03-26 07:59:39 -03:00
Tharo 02eafced87 sampleconv: Improve WAV SMPL chunk handling, properly handle (#1862)
odd chunk sizes

* Read WAV SMPL chunks for note info when INST chunks are not available

* Populate the SMPL chunk on conversion to wav

* Properly handle unaligned (odd) WAV chunk sizes
2026-03-09 08:32:36 -03:00
Tharo 826bc7588e Soundfont Compiler: Implement fine-tuning in the final tuning calculation (#1863) 2026-03-09 07:47:11 -03:00
Jordan Longstaff 04d96d3d34 Bombers Part 1: Rename (used) assets (#1847)
* Bombers Part 1: Rename (used) assets

* Fix duplicate definition

* Suggested renames
2026-02-18 07:53:53 -03:00
Tom Overton 6a2658058a Match various Bg_*_Bombwall actors for JP 1.1 (#1856) 2026-02-10 08:57:12 -03:00
Tom Overton b826285986 Match Bg_Fire_Wall for JP 1.1 (#1855) 2026-02-10 08:10:28 -03:00
Tom Overton 1ffe903d31 Match Bg_F40_Switch for JP 1.1 (#1854)
* Match `Bg_F40_Switch` for JP 1.1

* Put some data and BSS behind the version flag too

* Delete comment
2026-02-10 07:59:32 -03:00
Tom Overton 035595f37c Match Bg_Ingate for JP 1.1 (#1857) 2026-02-09 08:09:31 -03:00
Tom Overton 25e34ec140 Match Bg_Dblue_Balance for JP 1.1 (#1853)
* Match `Bg_Dblue_Balance` for JP 1.1

* Respond to review
2026-02-09 08:00:10 -03:00
Tom Overton ad7a80cb8f Match Bg_Crace_Movebg for JP 1.1 (#1852) 2026-02-05 08:19:11 -03:00
Anghelo Carvajal d358e1d213 [n64-jp-1.1] stackcheck.c matched (#1844)
* Match stackcheck

* format

* review
2026-02-04 20:22:56 -08:00
Jordan Longstaff 505f4b65c8 Rename globals related to textbox and icon scaling (#1846) 2026-02-04 19:29:12 -08:00
Anghelo Carvajal 788a22c3cb Allow atblgen to process sequence_order.in with empty lines in between lines for building on Macos (#1850)
* Allow atblgen to process `sequence_order.in` with empty lines in between other lines

* Fix memory leak issues and missing flags in makefile

* FIx warning that apparently only appeared because optimization flags are now enabled

* Skip empty lines at the beginning of the file
2026-02-04 18:01:48 -08:00
Tom Overton cb828147e1 Match Boss_Hakugin for JP 1.1 (#1851) 2026-02-04 08:35:28 -03:00
Jordan Longstaff 0877ce4adf Document EnMaruta (#1839)
* Document `EnMaruta`

* Document type from params

* Rename display lists properly

* Format

* Add ASCII picture to explain DL array

* Use boolean values for isRetracting

* Shorten name of zero vector

* Rename to gPracticeLogWholeDL

Co-authored-by: Anghelo Carvajal <angheloalf95@gmail.com>

* Forgot to rename the other reference

* Rename to SetupRiseThroughFloor

* Add comments marking "on floor setup" as theory-only

---------

Co-authored-by: Anghelo Carvajal <angheloalf95@gmail.com>
2025-12-15 07:29:53 -03:00
Jordan Longstaff b84d745393 Name four global variables in z_message.c (#1832)
* Name static arrays for SoDT skip message IDs

* Rename two more static variables

* Convert hex drop thresholds to decimal

* Rename to text IDs
2025-12-13 17:04:05 -03:00
Jordan Longstaff 508d8bb07a Document number input display and control functions (#1840) 2025-12-09 13:52:17 -03:00
Jordan Longstaff f75a5e1d2b Document func_808B849C (#1841)
* Document `func_808B849C`

* Clarify doc about number returned

Co-authored-by: Anghelo Carvajal <angheloalf95@gmail.com>

* Add number comparisons

* Try arithmetic in remains function

* Reverse addition operation - will it break matching?

---------

Co-authored-by: Anghelo Carvajal <angheloalf95@gmail.com>
2025-12-09 12:46:54 -03:00
Jordan Longstaff 311cdd9db0 Rename multiple variables in MessageContext (#1837)
* Rename multiple variables in `MessageContext`

* Fix errors

* Better rename for price fields

* Rename two more fields related to number inputs

* More renames for text line positioning fields

* Fix copy-paste error
2025-12-09 12:26:52 -03:00
Jordan Longstaff 18a8a1bea7 Rename WEEKEVENTREG_73_80 (#1842) 2025-12-09 08:22:23 -03:00
Isghj d6143abe52 EnDnk Documented (#1831)
* Dnk: some docs

* Dnk: more docs

* Dnk: format

* Dnk: More docs

* Dnk: more docs

* Dnk: more docs

* Dnk: specify variants

* Pr2: requested changes
2025-12-09 07:51:03 -03:00
Derek Hensley 7b96e58622 Multiversion code support (n64-jp-1.1) (#1826)
* setup n64-jp-1.1 disasm

* Add versions

* New microcode

* Bootstrap z_sram

* Bootstrap ovl_file_choose

* Bootstrap kaleido scope

* Bootstrap BgHeavyBlock

* MessageContext shift

* SaveContext shift

* ItemId shift

* Fix `PLAYER_CSACTION` shift

* format

* Add JP only to Heavy Block Description

* Makefile multi version comment

---------

Co-authored-by: Tom Overton <tom.overton@outlook.com>
2025-12-08 21:11:07 -08:00
Jordan Longstaff f6b17e2358 Document textbox types, backgrounds and two related global array variables (#1835)
* Document `D_801CFC78`, `func_80150A84` and textbox types

* Format

* Textbox background enum

* More enum usages

* Rename D_801D03A8

* Fix value of TEXTBOX_BG_NONE

* Convert background type enum to macros

* Restore enum, fix BSS ordering

* Rename to SetTextboxColor

* More BSS fixing
2025-12-06 15:32:14 -08:00
Jordan Longstaff f973883b06 Document func_80148CBC (#1836)
* Document `func_80148CBC`

* Add doc comment
2025-12-06 14:36:31 -08:00
Isghj 5898c3e2b0 EnPoComposer and object_po_composer further documented (#1833)
* PoComposer: some docs

* PoComposer: the rest of the object documented

* PoComposer: docs tweaked

* PoComposer: missing weekevent reg in a schedule file wasnt found by rename script

* PoComposer: document tweaks

* PoComposer: forgot the texture name
2025-12-06 12:03:15 -08:00
Isghj cc4a063e0c Fix rename_sym.sh tool: functions.txt/variables.txt (#1829)
* rename_sym: fixed to work with new disasm functions/variables locations

* rename_sym: re-enabled asm
2025-12-05 09:06:54 -03:00
Jordan Longstaff 92be14f00e Document func_801514B0 (#1834)
* Document `func_801514B0`

* Add transformation enum reference

* Rename to ShowDescription

* Format
2025-12-04 08:48:58 -03:00
Isghj 64d2e009fb EnFz and object_fz: Freezard documented (#1828)
* Freezard: some docs

* Freezard: more docs

* Freezard: most function names

* Freezard: last function named

* Freeza: more docs

* Freezard: oops wrong actor name

* Fz: more docs

* Fz: more docs

* Fz: Object named

* Fz: Object named

* Fz: changed my mind, function names changed to reflect old OOT behavior not seen in this game, in case someone confuses them

* Freezer: docs

* Free: more docs

* F: format

* Fz: more docs

* Fz: format

* EnFz: more docs, format

* Fz: More minor docs

* Fz: more docs, format

* Apply suggestions from code review

Co-authored-by: Anghelo Carvajal <angheloalf95@gmail.com>

* EnFz: More requested changes

* Fz: updated function declarations

* EnFz: one of the flags was still 0

* Fz: updated functions.txt for disasm

* Apply suggestions from code review

Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>

---------

Co-authored-by: Anghelo Carvajal <angheloalf95@gmail.com>
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
2025-11-14 15:48:06 -08:00