Commit Graph

1751 Commits

Author SHA1 Message Date
Roland 60b0d94e2a d_a_obj_auzu (#935)
* 59% matching in .text

* d_a_obj_auzu 100% for demo and retail

* Named all fields of daObjAuzu::Act_c

* All fields named
2026-03-01 18:36:56 -05:00
Roland 034b90bfdc d_a_daiocta and d_a_daiocta_eye matching (#934)
* Initial work; 25% matching in .text

* 27% matching in .text

* Match daDaiocta_c::modeProc

* 56% matching in .text

* 61% matching in .text

* 69% matching in .text

* 74% matching in .text

* 84% matching in .text

* daDaiocta_Eye_c 31%

* Match daDaiocta_Eye_c node callbacks

* daDaiocta_Eye_c 69%

* daDaiocta_Eye_c 85%

* daDaiocta_Eye_c 100% for retail and demo

* daDaiocta_c 96%

* daDaiocta_c 100% for retail and demo

* Field name cleanup

* More field naming

* Implement {is_, to_, to_dis}appear daObjAuzu inlines

* Misc code formatting changes

* Use JntHitType enum (d_a_daiocta)

* Apply suggestions from code review

Co-authored-by: LagoLunatic <LagoLunatic@users.noreply.github.com>

* Use fopAcM_SetMtx inline

---------

Co-authored-by: LagoLunatic <LagoLunatic@users.noreply.github.com>
2026-02-27 14:04:36 -05:00
SuperDude88 1d96a4c988 d_a_fgmahou OK (#932)
* d_a_fgmahou OK

* Some Cleanup

- Add offset comments
- Name some class fields
- Use a couple inlines from the map
2026-02-26 14:46:54 -05:00
TetrisGG 847a5e98bf d_a_obj_mkie - matching retail (#931)
* d_a_obj_mkie - matching

* review changes
2026-02-15 10:23:06 -05:00
Briggs Baltzell ca9481dcc9 d_cloth_packet matching (#928)
* Match dCloth_packet_c::setMtx

* Match dCloth_packet_c::setGlobalWind

* Match dCloth_packet_c::dCloth_packet_c constructor implementation

* Match dCloth_packet_c::getFactor and get_cloth_anim_sub_factor implementation

* Match dCloth_packet_c::cloth_move implementation

* Match dCloth_packet_c::setNrm implementation

* Match dCloth_packet_c::init and default_factor_checkCB implementation

* Match dCloth_packet_c::draw implementation

* Match dCloth_packet_c::cloth_draw implementation

* Match dCloth_packet_c::plot implementation

* Match dCloth_packet_c::TexObjLoad implementation

* Match dCloth_packet_c::TexObjInit implementation

* Match dCloth_packet_c::TevSetting implementation

* Match dCloth_packet_c::dCloth_packet_create implementation

* Match dCloth_packet_c::TevSetting implementation

* Match dCloth_packetXlu_c::TevSetting implementation and make dCloth_packet_c members protected

* Match dCloth_packetXlu_c::cloth_draw implementation

* Match dClothVobj03_c::cloth_copy implementation and update member definitions

* Match dClothVobj04_c, dClothVobj05_c, and dClothVobj07_0_c::cloth_copy implementations and update member definitions

* Match dClothVobj03_c::init implementation, update cloth_counter definitions, and add new member variables

* Match `dClothVobj04_c::init`, `dClothVobj05_c::init`, and `dClothVobj07_0_c::init` implementations, and add new member variables.

* Match `dClothVobj03_c::dClothVobj03_create` and constructor implementations, update member definitions, and add new logic checks.

* Match `dClothVobj03_c::cloth_move` implementation

* Match `dClothVobj04_c`, `dClothVobj05_c`, and `dClothVobj07_0_c::cloth_move` implementations

* Match `dClothVobj03_c`, `dClothVobj04_c`, `dClothVobj05_c`, and `dClothVobj07_0_c::TexObjInit` implementations, update member definitions, and initialize `mTlutObj`.

* Match `TexObjLoad` implementations for `dClothVobj03_c`, `dClothVobj04_c`, `dClothVobj05_c`, and `dClothVobj07_0_c`.

* Fix `dClothVobj04_c::cloth_move`

* Match `dClothVobj04_create`, `dClothVobj05_create`, and `dClothVobj07_0_create` implementations, update parameter definitions, and add new constructor logic.

* Update parameter names in `dClothVobj05_VtxFactorCB` and `dClothVobj07_0_VtxFactorCB` for consistency.

* Adjust parameter values in `dClothVobj05_create` and `dClothVobj07_0_create` for consistency with expected behavior.

* Match `dClothVobj05_VtxFactorCB` and `dClothVobj07_0_VtxFactorCB` implementations and update return logic.

* Fix constructors

* Refactor repetitive parameter assignments in `dCloth_packet_c` with `setParam` and `setWindPower` for cleaner and more maintainable code.

* Add `setFactorCheckCB` call in `dCloth_packet_c` initialization

* Refactor `dCloth_packet_c` and related classes to eliminate redundant success checks with `chkCreateBuff` helper method.

* Refactor `dCloth_packet_c` and related classes to use getter methods for cleaner access and rename methods for improved clarity.

* Simplify constructors for `dClothVobj03_c`, `dClothVobj04_c`, `dClothVobj05_c`, and `dClothVobj07_0_c` by removing redundant parameters.

* Replace `field_0x109` with `mIsIndoors` for improved clarity and consistency across `dCloth_packet_c` and related classes.

* Replace `VECDotProduct` with `inprod` method in `dCloth_packet_c` for improved readability and modern syntax usage.

* Make `top_pointer` and `cloth_counter` members private in multiple `dClothVobjXX_c` classes for encapsulation.

* Match cloth creation functions

* Add `l_alpha_matDL` assets and update `GXCallDisplayList` usage in `dCloth_packetXlu_c`

* Match dCloth_packet_c::init

* Match dCloth_packet_c::setNrm

* Refactor dCloth_packet_c to use mDoMtx_stack_c methods

* Match `get_cloth_anim_sub_factor` implementation in `dCloth_packet_c`.

* Refactor `getFactor` in `dCloth_packet_c` to use a bitmask for neighbor checks, enhancing code clarity and efficiency.

* Match dCloth_packet_c::cloth_move

* Match dCloth_packet_c::setGlobalWind

* Match dCloth_packet_c::plot implementation

* Remove unused virtual function declarations

* Update `d/d_cloth_packet.cpp` to Matching in configure.py

* Refactor field_0x108 and mIsIndoors to boolean types, rename, and add explanatory comments.

* Update `d/d_cloth_packet.cpp` to `MatchingFor("GZLE01")` in configure.py

* Add new material and alpha material configurations for `d_cloth_packet` across GZLP01, GZLJ01, and D44J01

* Update `d/d_cloth_packet.cpp` to `Matching` in configure.py

* Update `d/d_cloth_packet.cpp` to `MatchingFor("GZLE01", "GZLP01")` in configure.py

* Add conditional GXSetNumIndStages and resetVcdVatCache for non-JPN versions in `dCloth_packet_c::draw`

* Update `d/d_cloth_packet.cpp` to `MatchingFor("GZLJ01", "GZLE01", "GZLP01")` in configure.py

* Matched dCloth_packet_c::dCloth_packet_c for `VERSION_DEMO` in `d/d_cloth_packet.cpp`

* Matched dCloth_packet_c::cloth_move for `VERSION_DEMO` in `d/d_cloth_packet.cpp`

* Matched dCloth_packet_c::draw for `VERSION_DEMO` in `d/d_cloth_packet.cpp`

* Matched dCloth_packet_c::TexObjInit for `VERSION_DEMO` in `d/d_cloth_packet.cpp`

* Matched dClothVobjXX_c::TexObjInit for `VERSION_DEMO` in `d/d_cloth_packet.cpp`

* Update `d/d_cloth_packet.cpp` to `Matching` in configure.py

* Replaced direct member access with getter methods in `d/d_cloth_packet.cpp`

* Added `f` suffix to floating-point literals in `d/d_cloth_packet.cpp` for consistency.
2026-02-12 01:42:21 -05:00
ssorenson130 579931b72c d_a_obj_volcano matching (#924)
* start

* startfire

* some partial matches

* matching

* cleanup

* demo matching
2026-02-11 22:45:53 -05:00
Roland 2168699559 d_a_npc_rsh1 matching (#927)
* Initial work

* 14% matching in .text
- Add some of the static data
- Match sinit function
- Match HIO constructor
- Match _create
- Match some other trivial functions

* Match CreateHeap

* 20% matching in .text

* 31% matching in .text

* 34% matching in .text

* 38% matching in .text

* 51% matching in .text

* createShopList work

* More createShopList work

* 54% matching in .text: Match createShopList

* 57% matching in .text

* 68% matching in .text

* Variable name updates

* 75% matching in .text

* 81% matching in .text

* Match lookBack

* d_a_npc_rsh1 100% for demo and retail

* Replace magic constants with applicable enums

* Give some member fields trivial names and name some method parameters

* Fix a few renaming errors

* More renaming work

* Rename HIO fields and rest of actor fields

* Replace magic numbers associated with mItemNo
2026-02-11 22:40:15 -05:00
Roland c79fa65efd d_a_npc_ls1 matching (#925)
* Match daNpc_Ls1_c::create, decideType, and ctor

* 16% matching in .text
-Match daNpc_Ls1_c::CreateHeap
-Match daNpc_Ls1_c::itemCreateHeap
-Match daNpc_Ls1_c::handCreateHeap
-Match daNpc_Ls1_c::_delete
-Match other trivial functions

* Add hio_prm_c

* 27% matching in .text
-Add some static data
-Match daNpc_Ls1_c::endEvent
-Match daNpc_Ls1_c::isEventEntry
-Match daNpc_Ls1_c::execute
-Match daNpc_Ls1_c::bodyCreateHeap
-Match some more trivial funcs

* 33% matching in .text
-Match daNpc_Ls1_c::create_init
-Match daNpc_Ls1_c::chngAnmTag
-Match daNpc_Ls1_c::ctrlAnmTag
-Match init_LS1_#n() funcs
-Match searchActor funcs

* Add daNpc_Ls1_c::anm_prm_c struct and associated static data

* 39% matching in .text
- Matched daNpc_Ls1_matAnm_c::calc
- Matched static node callbacks
- Matched daNpc_Ls1_c::setAnm_anm
- Matched daNpc_Ls1_c::setAnm_NUM
- Matched daNpc_Ls1_c::chngAnmAtr
- Misc code formatting changes

* 52% matching in .text
- Match daNpc_Ls1_c::play_animation
- Match daNpc_Ls1_c::set_mtx
- Match ResID funcs
- Match daNpc_Ls1_c::setBtp
- Match daNpc_Ls1_c::setMat
- Match daNpc_Ls1_c::setBtk
- Match daNpc_Ls1_c::init_texPttrnAnm
- Match daNpc_Ls1_c::play_btp_anm
- Match daNpc_Ls1_c::play_btk_anm
- Match daNpc_Ls1_c::ctrlAnmAtr
- Match daNpc_Ls1_c::setAnm_ATR
- Match daNpc_Ls1_c::chk_parts_notMov
- Match daNpc_Ls1_c::cut_init_LOK_PLYER
- Match daNpc_Ls1_c::cut_move_WAI
- Match daNpc_Ls1_c::cut_init_ANM_CHG
- Match daNpc_Ls1_c::set_action

* Update comments

* Match daNpc_Ls1_c::_draw

* 63% matching in .text
- Match member J3D node callbacks
- Match daNpc_Ls1_c::eye_ctrl
- Match daNpc_Ls1_c::next_msgStatus
- Match daNpc_Ls1_c::getMsg
- Match daNpc_Ls1_c::chk_talk
- Match daNpc_Ls1_c::setEyeCtrl
- Match daNpc_Ls1_c::clrEyeCtrl
- Match daNpc_Ls1_c::setAttention
- Add misc enums
- Add a_cut_tbl

* 66% matching in .text
- Matched daNpc_Ls1_c::searchByID
- Matched daNpc_Ls1_c::partner_search_sub
- Matched daNpc_Ls1_c::partner_search
- Matched daNpc_Ls1_c::chkAttention
- Marched daNpc_Ls1_c::shadowDraw

* 75% matching in .text
- Match daNpc_Ls1_c::anmAtr
- Match daNpc_Ls1_c::getMsg_LS1_0
- Match daNpc_Ls1_c::chk_talk
- Match daNpc_Ls1_c::setStt
- Match daNpc_Ls1_c::get_playerEvnPos
- Match daNpc_Ls1_c::chkTelescope
- Match daNpc_Ls1_c::wait_1
- Match daNpc_Ls1_c::wait_4
- Match daNpc_Ls1_c::talk_1
- Match daNpc_Ls1_c::demo_action1

* Match daNpc_Ls1_c::wait_3

* 100% matching for both demo and retail

* Update comments

* Initial refactoring work

* Renaming work & declaring functions in f_op_msg_mng header

* Refactoring continued

* Last bit of renaming work

* Add missing include
2026-02-11 22:31:05 -05:00
Roland 1763262970 d_a_oship matching (#929)
* Initial work, 30% matching in .text

* 42% matching in .text

* 51% matching in .text

* 72% matching in .text

* 75% matching in .text

* 93% matching in .text

* d_a_oship 100% for both demo and retail
2026-02-11 22:24:08 -05:00
Mike Lester 9cc61c4058 Fix up a shadow-related variable/parameter names (#920)
* Fix up a shadow-related variable/parameter names

* Fix compilation errors in d_a_obj_barrel.cpp
2026-01-13 01:01:35 -05:00
Roland ba4a7b481c d_a_obj_buoyrace - matching (#921)
* 13% matching in .text

* 32% matching in .text

* d_a_obj_buoyrace 98%

* d_a_obj_buoyrace demo 98%

* link d_a_obj_buoyrace

* Small refactor

* More refactoring

* Small renaming work

* Fix errors

* Variable name cleanup
2026-01-12 14:17:01 -05:00
Roland 6893c2588e d_a_goal_flag - matching (#918)
* initial work on d_a_goal_flag

* Update config.yml to extract symbols from d_a_goal_flag; also add l_pos and l_texCoord

* 17% matching in .text

* daGoal_Flag_c::CreateHeap matched

* RopeMove 99%

* Update d_a_goal_flag.cpp

* getRacePath 100%

* 31% in .text

* 47% matching in .text

* 56% matching in .text

* 70% matching in .text
Add definitions to inlines in daGFlag_packet_c and fully matched some daGFlag_packet_c methods.

* 84% matching in .text
Match daGFlag_packet_c::draw

* 91% matching in .text
- Formatting tweaks
- Match TimerExecute
- Add fopMsgM_MiniGameTerminater_create inline
- Move daGoal_Flag_c::_create in the correct place to match .data

* d_a_goal_flag matching 100% for retail

* d_a_goal_flag demo 99%

* Resolve _create fakematch

* d_a_goal_flag demo matching 100%

* link d_a_goal_flag for demo

* Renaming of fields/variables and some refactoring

* Refactoring continued
- Change direct calls to VECDotProduct to cXyz::getDotProduct

* Named more HIO fields and packet fields

* Implement fopMsgM_MiniGameStarter_create

* Name all used HIO fields

* Named all fields in daGoal_Flag_c

* Finishing touches
2026-01-09 13:09:23 -05:00
Lord-McSweeney ca83b5d1ae d_file_error matching (#915)
* d_file_error decompiled

* Use dComIfGs_getPalLanguage

* Resolve review comments

* d_file_error matching for non-debug
2026-01-01 14:14:13 -05:00
LagoLunatic a0d59ce00e Add const to TVec2 ctor to match TVec3 2025-12-29 14:12:14 -05:00
LagoLunatic 10a6460011 J3DCluster almost matching 2025-12-29 14:09:54 -05:00
LagoLunatic a7421f5f66 Add UNUSED macro, enable clangd unused parameter warnings 2025-12-29 13:39:55 -05:00
LagoLunatic ab23a2693d msgStatus cleanup 2025-12-29 13:34:48 -05:00
LagoLunatic d272deb179 ospbox OK for demo 2025-12-29 13:28:29 -05:00
LagoLunatic 1c3762cf14 Move daPy methods into d_a_player headers 2025-12-29 13:20:45 -05:00
LagoLunatic 8651f98984 Make getEvent return a pointer instead of a reference, resolve tbox fakematch 2025-12-29 13:05:34 -05:00
LagoLunatic e095de7b01 Fix d_a_obj_gnnbtltaki and d_a_obj_gnndemotakie create_heap 2025-12-29 12:59:43 -05:00
Nuss cdaed9aadd d_a_obj_gnndemotakie - matching (#914)
* matching 100%

* D44J01 matching

* demo stuff
2025-12-29 12:47:20 -05:00
LagoLunatic bc8b894e21 Inlines cleanup 2025-12-27 21:32:04 -05:00
LagoLunatic 8787f8a1f7 Resolve tevStr fakematches 2025-12-27 21:32:04 -05:00
LagoLunatic 19472bf60d Fix JSystem PCH breaking decomp.me 2025-12-27 21:32:04 -05:00
LagoLunatic bc1ca84bdc Remove fake cSAngle::operator= 2025-12-27 21:32:04 -05:00
LagoLunatic 48dcebd9e8 Misc cleanup 2025-12-27 21:32:04 -05:00
LagoLunatic 4547fcca91 d_a_obj_movebox: Remove attr inline fakematch 2025-12-27 21:32:04 -05:00
LagoLunatic e64620bf7e J3DGXColor ctors to match debug maps 2025-12-27 21:32:04 -05:00
Roland 49d9ed5757 d_a_obj_ajav - matching (#911)
* initial work on d_a_obj_ajav

* matched Act_c::_create and Part_c::init_data

* initialized cXyz arrays

* 44% matching in .text

* more work on d_a_obj_ajav

* 73% matching in .text

* 83% matching in .text

* 99% of .text matching

* 100% .data matching

* fakematch _execute and link d_a_obj_ajav

* demo matching

* initial code cleanup

* named all fields in Act_c and some Part_c fields

* more documentation

* make a fakematch slightly less fake

* fix _execute for demo

* named more fields in Part_c

* named most fields and parameters

* finishing touches

* update d_a_obj_ajav .cpp and .h

* Commit review suggestions
2025-12-27 18:42:16 -05:00
123456789758 d0852db127 d_meter - 99% matching (#907)
Co-authored-by: ‎ ‎ ‎ <‎ ‎ ‎>
2025-12-27 16:23:15 -05:00
Roland 24708b315d d_a_warpgn (#910)
* initial work on daWarpgn_c

* 76% of .text matching

* d_a_warpgn matching for retail

* fixed initWarpArrive for GZLJ01

* d_a_warpgn matching for both demo and retail; reformat field names

* Update configure.py

* Update d_a_warpgn.cpp

* unlink from demo and commit suggestions from review
2025-12-23 23:51:56 -05:00
Zeclos 65611e09a4 D_a_npc_hi1 matching for retail (#897)
* bit too difficult for me for now, might go back later

* progress

* getmsg

* logic matching data isnt

* data section matches

* mathubcg 100%

* cleanup

* revert this change

* final cleanup and configure.py

* nevermind cleanup

* Equivalent onstead of matching

* removed padding

* cleanup code comments and a bit more

* matching

* cleanup

* matching for retail

* little bit of cleanup
2025-12-23 23:20:37 -05:00
Roland a0476593c9 d_a_obj_rflw matching (#908)
* initial work on d_a_obj_rflw

* 50% matching in .text

* d_a_obj_rflw 100% for retail and demo

* removed goto from CreateHeap

* cleaning up d_a_obj_rflw

* Update d_a_obj_rflw.cpp

Co-authored-by: LagoLunatic <LagoLunatic@users.noreply.github.com>

---------

Co-authored-by: LagoLunatic <LagoLunatic@users.noreply.github.com>
2025-12-19 00:04:05 -05:00
LagoLunatic 729f81babf Fix HIO load issues for d_a_player_main 2025-12-10 17:31:47 -05:00
SuperDude88 925c338bd6 Most of c_damagereaction (#903)
* Most of c_damagereaction

Still planning to go back and finish dr_damage_anime

* Match dr_damage_anime

* Fix Last Instruction Issues
2025-12-05 09:12:14 -08:00
LagoLunatic 8ce8d2f541 Add JSystem PCH to fix weak function order (#904)
* Add JSystem PCH

* Fix build issues, remove weak order fakematches, and fix functionvalue weak func order
2025-12-05 09:11:53 -08:00
LagoLunatic 3393a348e1 Remove dCcS::SetMass-related fakematches
No longer necessary with the PCH for some reason.
2025-11-24 18:51:42 -05:00
LagoLunatic c076a8000f Match mDoLib_setResTimgObj 2025-11-24 18:49:01 -05:00
LagoLunatic c1d05201b6 Remove a functionvalue fakematch 2025-11-17 16:27:09 -05:00
123456789758 9075155201 d_msg - 99% matching (#899)
Co-authored-by: ‎ ‎ ‎ <‎ ‎ ‎>
2025-11-14 19:51:12 -08:00
Jasper St. Pierre 909a2a0dd6 d_kankyo_wether work 2025-11-11 01:58:46 -08:00
123456789758 9536fe8336 Bosses - misc. cleanup/improvements (#898)
Co-authored-by: ‎ ‎ ‎ <‎ ‎ ‎>
2025-11-10 23:52:23 -08:00
Kristopher Early 2c7dbdc59d d_a_obj_gnnbtltaki OK (#887)
* d_a_obj_gnnbtltaki OK

* d_a_obj_gnnbtltaki Cleanup

* set d_a_obj_gnnbtltaki as matching.

* d_a_obj_gnnbtltaki OK for GZLJ01, GZLE01, GZLP01

* Update d_a_obj_gnnbtltaki.cpp

* d_a_obj_gnnbtltaki Retail and Demo OK
2025-11-10 23:49:10 -08:00
KallePM e7b951841e d_a_yougan (#878)
* d_a_yougan: match retail

* d_a_yougan: match demo

* d_a_yougan: remove nonmatching comments
2025-11-10 23:48:23 -08:00
KallePM cf668ea219 d_a_kmon (#868)
* d_a_kmon: match for retail

* d_a_kmon: match for demo

* d_a_kmon: remove nonmatching comments
2025-11-10 23:46:41 -08:00
LagoLunatic 27f0df12eb Fix G_CM3D_F_INF define 2025-09-28 14:01:14 -04:00
LagoLunatic eca6bd2d13 Minor cleanup 2025-09-28 13:57:06 -04:00
LagoLunatic d89fe27888 Use composition instead of inheritance for most f_op classes 2025-09-25 15:59:25 -04:00
LagoLunatic 0e9059b633 d_a_dr2 matching for demo 2025-09-19 18:44:06 -04:00