Commit Graph

1292 Commits

Author SHA1 Message Date
Nikolaj Jensen Ulrik d62ccfae12 d_a_obj_hat 100% (#696)
* nearly matching obj_hat

* use inline instead

* cleanup

* remove debug map

* renaming member variables

* fixing missing inlines in setMtx

* last couple of renames, status to Matching

* bit more inlining

* Apply suggestions from code review

Co-authored-by: LagoLunatic <LagoLunatic@users.noreply.github.com>

* fixing review comments, missing returns

---------

Co-authored-by: LagoLunatic <LagoLunatic@users.noreply.github.com>
2025-03-02 16:16:25 -05:00
LagoLunatic 6c75c400f2 Reorder dComIfG inlines 2025-03-01 00:54:57 -05:00
LagoLunatic 6e83a87f42 Implement dCom attention inlines 2025-03-01 00:54:52 -05:00
LagoLunatic 6c6b5a95ac d_a_lwood OK 2025-02-28 18:08:31 -05:00
LagoLunatic 5571ec74e4 Document the second param to joint callback functions 2025-02-28 18:04:05 -05:00
Ross Newman fdfb69f055 d_a_tornado (#697)
* d_a_tornado 100%

* update member names

* fixes

* fix constant

* add compiler flag

* return BOOL type

* Apply suggestions from code review

Co-authored-by: LagoLunatic <LagoLunatic@users.noreply.github.com>

---------

Co-authored-by: LagoLunatic <LagoLunatic@users.noreply.github.com>
2025-02-28 01:49:58 -05:00
LagoLunatic c61fe4a335 Use "switch no" instead of "switch id/index" 2025-02-27 18:14:50 -05:00
mattias-blum f2264eea7c d_a_tag_so 100% (#694)
* d_a_tag_so 100%

Small one, nothing to comment on

* PR changes made

Reverted variable names, better use of inlines

* small fix, removed extra semi
2025-02-25 20:53:21 -05:00
mattias-blum ea840c9a23 d_a_leaflift 100% (#693)
* d_a_leaflift 100%

* d_a_leaflift_static 100%

Additional formatting changes plus variable re-naming's due to added context from `d_a_leaflift_static`

* PR changes made, renamed other variables

The m43C-m43E flags seem to be flags relating to Link's gliding state but couldn't figure out the order of them. m43F seems to be some timer.

* additional PR changes
2025-02-25 19:46:12 -05:00
LagoLunatic 8ed6cad381 d_timer OK 2025-02-23 20:57:01 -05:00
LagoLunatic 33f76d9968 More cleanup 2025-02-23 20:56:27 -05:00
LagoLunatic c4ad9f7241 Various cleanup 2025-02-23 19:59:54 -05:00
mattias-blum 730b74e2e3 d_a_shutter2 100% (#692)
* d_a_shutter_2 100%

- Code should be consistent with `d_a_shutter`
- A couple of variables still remain unnamed

* fixed issue in configure.py, git related

* forgot to set to matching

* weak function ordering in fine, removed param

* merged decleration and instantiation of minVel, maxVel

* PR changes

_create() still has me stumped. You would think that the return after that if statement would be `return cPhs_COMPLEATE_e;` but it just, doesn't exist? Adding any sort of return statement causes it not to match. Potential bug forgotten by the devs maybe?
2025-02-23 19:42:10 -05:00
mattias-blum 8338fd56e6 d_a_shutter 100% (#691)
* d_a_shutter 100%

- Wasn't sure what to name some of the used member variables that have yet to be assigned names (ex. `field_0x339`) but if you have an intuitive guess based on the code/previous actors I'd be happy to change them

* Requested PR changes made

The only thing I was unsure about was the new name for `mCount`. I settled on `mFrameTimer` because it's initialized to 30 and counts down every frame (assuming `_execute()` is called every frame).

* changed typing of `mbIsSwitch` to remove unnecessary cast

* file reference changes
2025-02-22 21:06:13 -05:00
mattias-blum 3f00e1e347 d_a_steam_tag 100% (#690)
* d_a_steam_tag 100%

Added inline functions to `d_point_wind` that were referenced in this TU

* PR changes added

- Also removed an unused local variable, renamed another
- Seems my struct had one member too many so I removed the last one ('field_0x0F`) and resized `field_0x0E` accordingly
2025-02-20 18:38:33 -05:00
mattias-blum 5dcccc228f d_a_tori_flag 100% (#689)
* d_a_tori_flag 100%

Had to add a constructor for `dCloth_packet_c`, may want to reconsider the naming of certain members of `daTori_Flag_HIO_c` in the future.

* d_a_tori_flag 100% configuration

* Requested PR changes made

* added proper inline functions
2025-02-19 19:48:55 -05:00
LagoLunatic f51b9b65df A few small matches for 2dnumber/meter 2025-02-11 17:08:48 -05:00
LagoLunatic 458c40ede8 Translate strings in fopAcM_entrySolidHeap 2025-02-11 16:25:06 -05:00
LagoLunatic 7297cbaf38 c_m3d done except for regalloc 2025-02-05 18:04:26 -05:00
LagoLunatic 9875a39ee6 Mark d_a_obj_hha as equivalent, and fix various small things in it 2025-02-01 16:42:58 -05:00
LagoLunatic 025b7e459a Switch return type of _execute/_draw/_delete to be bool by default instead of BOOL
It's not completely consistent, but it seems like the majority used `bool`, and only a handful used `BOOL`. So I switched all of them to `bool` except for 13 TUs that stopped matching when changed like this.
2025-02-01 16:17:46 -05:00
Azurpourpre 39aace2c91 d_a_obj_hha 100% (#688)
* daObjHhaPart_c : progress on init_data, set_mdl_area, set_bgw, init_mtx

* daObjHhaSplash_c::create_s match

* daObjHhaYgush_c::create_area match

* daObjHhaYgush_c::init_data match

* daObjHhaYgush_c::init_mtx match

* daObjHhaYgush_c::draw match

* daObjHha_c class definition

* exe_normal & draw_normal match

* daObjHha_c::create_heap match

* daObjHha_c::_create match

* daObjHha_c::_delete almost match

* daObjHha_c::check_sw

* daObjHha_c::set_tex match

* daObjHha_c::init_mtx match

* daObjHha_c::get_water_h

* daObjHha_c::set_splash_bottom_* & daObjHha_get_r match

* daObjHha_c::set_splash_bottom_stop_r match

* daObjHha_c::part_manager almost match

* daObjHha_c::ygush_manager match

* daObjHha_c::_execute almost match

* daObjHha_c::_draw match

* daObjHha_c::water_manager match

* Mthd match

* da_a_obj_hha object file match

* Cleaning & adding variable names

* Updating configure.py & cleaning

* fixing d_a_obj_hha constants symbol name

* Adding suggestions (zeldaret/tww/#688)

* Fixing d_a_obj_hha Mthd (as suggested in PR zeldaret/tww/#688)

* Reverting configure.py
2025-02-01 15:44:48 -05:00
LagoLunatic a52bb789da Rename HostIO mChildID to mNo
TP debug has an assert in d_a_obj showing the name of this variable is `M_no` there.
2025-01-31 15:49:44 -05:00
LagoLunatic 2ece7c9ce1 Create constants for m_Do_machine heap/buffer sizes 2025-01-31 15:35:43 -05:00
LagoLunatic 901bc51f40 d_a_npc_md work 2025-01-27 19:26:14 -05:00
LagoLunatic 02b21329ad GBAJoyBoot OK 2025-01-26 20:52:18 -05:00
LagoLunatic ffe54e0bea Mark funcs with weak func order issues as Equivalent, fix a few other issues 2025-01-23 21:52:41 -05:00
LagoLunatic 067b47185b Fix references to memcard gamedata struct size 2025-01-18 18:42:35 -05:00
LagoLunatic e8adc6c9e5 Rename more item enums 2025-01-17 20:58:43 -05:00
LagoLunatic 5400c43ea1 d_a_bk work 2025-01-17 20:04:27 -05:00
LagoLunatic 2a02484cdc JStudio/JMessage work and cleanup 2025-01-17 20:04:18 -05:00
LagoLunatic b5350e1d1a Minor cleanup 2025-01-14 23:23:26 -05:00
LagoLunatic e620f9328b Use _GX name typedefs 2025-01-14 22:47:21 -05:00
LagoLunatic d2426c53f7 Fix JUTXfb fakematch
This match (with the u32 cast) is more likely to be the real match based on the inlines called in TP debug.
2025-01-14 22:41:00 -05:00
LagoLunatic 8e44641465 Fix various data relocation differences in unlinked TUs 2025-01-14 22:11:08 -05:00
LagoLunatic 532bdb29ad Some initial work on HIO classes definitions for debug build 2025-01-11 22:10:44 -05:00
LagoLunatic d330c1e68a Add enums for items and disappears 2025-01-11 19:15:36 -05:00
LagoLunatic ca6bebcb4b Add more actor mode enums 2025-01-11 17:20:45 -05:00
Azurpourpre 3816b8d8f0 d_a_obj_rforce match (#686)
* d_a_obj_rforce match

* Adding suggestions (Pull Request zeldaret/tww/#686)
2025-01-10 23:48:07 -05:00
LagoLunatic 417ef8cacb Fix mDoHIO inlines 2025-01-08 15:49:00 -05:00
LagoLunatic f74fd75332 Misc cleanup 2025-01-08 15:42:47 -05:00
LagoLunatic 3d63a54587 Player inlines and enums 2025-01-08 15:05:14 -05:00
LagoLunatic b18a1e448a Add enums for island room numbers and indexes 2025-01-06 00:47:29 -05:00
LagoLunatic 37dbfd75de Add item button enum and talk button enum 2025-01-06 00:23:55 -05:00
LagoLunatic 4a0a89501d Match getMesgHeader on JPN 2024-12-28 21:34:40 -05:00
Jasper St. Pierre 3c660fa937 J2DBasePosition 2024-12-28 17:02:59 -08:00
LagoLunatic 06709dad7f d_a_obj_toripost documentation, d_a_rd wrong name fixes 2024-12-28 18:58:57 -05:00
Jasper St. Pierre 72bbd3ea1f f_op_msg_mng work 2024-12-28 15:33:02 -08:00
LagoLunatic f543b7b471 Add ASM define to wrap mwerks asm keyword 2024-12-28 15:45:24 -05:00
LagoLunatic f18e2b10dd Various cleanup for OSContext 2024-12-28 14:56:09 -05:00