* UNUSED attribute for variables and parameters in static segments and for all stack padding variables
* No more unused variable warnings
* Make pad variable names consistent
* Small cleanup
* Macro-ify stack padding
* Use stack padding for more variables not previously named pad
* Format
* Check unused parameter on gamestate overlays and pause menu
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
* Merge 2x u8 stack pads into 1x s16 stack pad in en_ik
* Remove UNUSED from function prototypes
* Suggested changes
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
* More unused variables
* Fix merge, updated for new versions
* Format
* questionable UNUSED and STACK_PAD more usage
* format
* format
* one more STACK_PADS in z_kaleido_map.c
---------
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
* rm PROJECT_DIR var from makefile
* fix tlutoffset missing 0x prefix
* fix FTOFIX32 redef warning
* `@bug:` -> `@bug`
* playerFloorPoly -> sPlayerFloorPoly
* fix settingChangeSuccessful use as bool
* fix broken english
* osEPiStartDma: use OS_MESG_PRI_HIGH
* EffectSsHahen_SpawnBurst: pass OBJECT_ for objId
* remove extra parens
* fix trailing comma warnings in enums
* EnRu1: decimal alpha
* fix parens
* fix ATELEM_SFX_NORMAL comment (collider "type" was renamed to material)
* fix comment in Math3D_TriChkPointParaYImpl
* use ANIMMODE_ more
* Remove leading 0s from enum comments (as they indicate octal in C)
* z_scene Some comments and function names
* review changes
* further fixing from comments
* vromAddr
---------
Co-authored-by: djevangelia <djevangelia>
* Document an includes style, apply to z_demo.c and z_play.c
* "reverse" style includes
* bss
* clarify what a "main header" is
* Update docs/includes.md
Co-authored-by: Tharo <tharo10600@gmail.com>
* Update docs/includes.md
---------
Co-authored-by: Tharo <tharo10600@gmail.com>
* [cc0 oot] Biri
* name biri anims (by usage, Z64Utils cant preview them)
* fixup bari/biri mixup
* EnBili cleanup
* biri cleanup
* biri: merge var ini with decl
* Document z_eff_ss_stone1.[ch]
* Incorporate feedback from PR review.
From https://github.com/zeldaret/oot/pull/2670:
- Shortened excessively verbose
suppressRTransFadeFlashAlphaStepAfterTwoFrames name to
suppressFadeFlash
- Fixed up comment that went waaaaaay beyond the column limit in
z_eff_ss_stone1.h
- Shortened comparison with 0 of variable bool semantics in
z_eff_ss_stone1.c
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
* Fix misnaming from PR review and document some more
From https://github.com/zeldaret/oot/pull/2670:
- shortenFadeFlash is incorrect - renamed to freezeFadeFlash
- Used `false` instead of 0 in EnArrow_Fly
- Elaborated comments about what exactly freezeFadeFlash does
Also added a few extra comments to z_eff_ss_stone1.c
* Ran clang-format
* More feedback from PR review, clarified comment
From https://github.com/zeldaret/oot/pull/2670:
- Change 0 to false in header comment
- Remove verbose speculation about former use of unused variable
- Made comment on use of viewDepth clearer
- Separated matrix and gfx code with a newline
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
* Marked the "1500" as being in units
---------
Signed-off-by: Gabriel Ravier <gabravier@gmail.com>
* BgSpot09Obj: document params type enum
* Address review comments
- Remove "objects" from description (has specific meaning in Zelda64 engine)
- Move BgSpot09ObjType enum to .h for use by external files
- Replace return 0/1 literals with false/true in func_808B1AE0
- Fix enum comments: remove "visible" terminology, correct tent is adult-only
---------
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
* Macro-ify access to pauseCtx->playerSegment regions.
Using macros to indicate which region in the player segment is being
accessed makes the memory layout more obvious and indicates the
intended level of memory ownership, particularly in the case of the
texture image at the start of the segment.
* Add clarifications for gameplay_keep details
* Uniform macro name for the render texture
* Comment
* Finish `EnExRuppy` documentation
* Rename throw distance field
* Move comments to enum type
* Use `EnHeishi1` type for guard
* Add comment on `EnHeishi1` supposition
* oot-gc-eu-dbg-proto OK
* add gc-eu-dbg-proto to readme
* mention overdump trimming for all debug roms
* rename gc-eu-dbg-proto to gc-eu-dbg-2
Rationale: first version to make it into decomp (which should also be the first one that surfaces) gets an un-numbered version name, then the second version gets -2, and so on
Reonu