* feat: Start decompiling ActorUnkCANS ctor and vfunc_10
* feat: Improve vfunc_10
* feat: Decompile vfunc_18 and 1C
* fix: Remove trailing return
* feat: Progress on vfunc_20
* fix: Rename symbol
* feat: Finish first run over vfunc_20
* feat: Improve vfunc_20
* feat: Improve vfunc_20
* feat: Heavily improve vfunc_20
Almost done
* feat: Keep vfunc_20 going, add UnkAngleStruct to Actor.hpp
* feat: Some polish on vfunc_20
That's about what I can do, there are some tweaks left but I'm unable to
get anywhere.
Kind of proud ngl
* feat: Rename symbols and match vfunc_24
* fix: Fix jp symbol conflict
* feat: Decompile vfunc_2C
* feat: Fix symbols and signatures
* fix: Match switch statement by adding every cases
* feat: Match func_ov063_02157fa4
* feat: Match func_ov063_02158424
* feat: Match func_ov063_02158448
* feat: Match func_ov063_02158490
* feat: Match func_ov063_02158b0c
* feat: Match func_ov063_02158b34
* feat: Decompile most of func_ov063_02158b98 (need regalloc fix)
* feat: Create inner classes of ActorUnkCANS, match some vfuncs
* feat: Update some dtor symbol and match some ctor
* feat: Decompile UnkStruct 02162ee8 ctor
* feat: Rename jp symbols
* feat: Match func_ov063_021590c8
* feat: Match func_ov063_02159dfc
* feat: Decompile some functions
* fix: Fix old accesses
* fix: More merge artifacts
* fix: More merge artifacts
* chore: Move structs around and fix some uses
* feat: Start decompiling func_ov063_02158db0
* feat: Decompile some vfunc
vfunc_0C is really really weird
* fix: Fix use of removed struct
* feat: Match func_ov063_02159258
* feat: Match func_ov063_02159494
* feat: Match func_ov063_021595a4
* feat: Match func_ov063_02159618
* feat: Match func_ov063_02159714
* feat: Match func_ov063_02159784
* fix: Move UnkAngleStruct to math.hpp
* fix: .data of ActorRollingStone & ActorShotArrow
* feat: Match func_ov063_021598fc
* fix: Cleanup code for func_ov063_021598fc
* feat: Match func_ov063_02159ca8
* feat: Match func_ov063_02159d68
* fix: Fix double declaration of func
* feat: Match func_ov063_02159e20
* feat: Decompile most of func_ov063_02159ec0
* feat: Match func_ov063_0215a428
* feat: Match func_ov063_0215a474
* feat: Update lots of symbols (mainly for jp)
* feat: Start decompiling two funcs with fx mul
* fix: Fix broken symbol def after merge
* feat: Match func_ov063_0215a514
* feat: Match func_ov063_0215a56c
* feat: Match func_ov063_0215a5a0
* feat: Match func_ov063_0215a5bc
* feat: Match func_ov063_0215a5d8
* feat: Decompile most of func_ov063_0215a678
* fix: Fix some regalloc order in func_ov063_0215a678
* feat: Update symbols and create unk class
* feat: Update CANS member with the new class
* feat: Update symbols, remove dead variables
* feat: Improve ctor and some local struct layout
* feat: Improve ActorUnkCANS ctor
* fix: Fix ActorUnkCANS members layout
* feat: Improve ActorUnkCANS ctor more
* fix: Fix wrong symbol reloc
* feat: Add intermediate struct and update symbols
* feat: Match some jp only code, symbols
* feat: Decompile part of func_ov063_0215a2c0
* fix: Fix jp only code in func_ov063_0215a2c0
* feat: Update symbols
* feat: Cleanup unused functions
* feat: Cleanup JP ifguards handling
* feat: Remove lot of useless temps, use DEG_TO_ANG where it seems appropriate
* feat: Small code cleanup
* Apply suggestions from code review
Co-authored-by: Alessevan <44125445+Alessevan@users.noreply.github.com>
* fix: Fix style
* feat: Apply suggestions from review
* feat: More code cleanup
* feat: Some more improvements
* fix: Remove auto-generated comment headers
* fix broken matches
* fix broken matches 2
---------
Co-authored-by: Alessevan <44125445+Alessevan@users.noreply.github.com>
Co-authored-by: Yanis002 <35189056+Yanis002@users.noreply.github.com>
* delink the overlay
* ItemManager_101 OK
* UnkStruct_027e0ce0_40_101 OK
* PlayerLinkActor_A0_1C_101 OK
* UnkStruct_027e09a4_54_101 OK
* UnkStruct_027e0cd8_0C_101 OK and MapObjectProfile_Derived6_101 OK
* UnkStruct_027e09b4_001 OK
* UnkStruct_027e09ac_001 OK
* UnkStruct_027e0cec_001 OK
* SysNew OK
* UnkStruct_027e0cec_18_001 OK
* UnkStruct_027e0ce0_34_001 OK
* UnkStruct_027e0d00_001 OK
* PassengerManager_001 OK
* UnkStruct_027e0cf8_08_00_001 OK
* UnkStruct_ov020_020e8544_001 OK
* code_020bfdd0 OK and code_020bfeec OK
* code_020c099c OK
* run ninja format
* delink what's left from overlay 1 (except dsprotect)
* fix regressions
* UnkStruct_027e0ce0_1C_001 97%
* UnkStruct_0204a110_001 OK
* UnkStruct_ov024_020d86a0_001 OK
* UnkStruct_ov000_020b50c0_001 OK
* GameModeCreate OK
* AdventureModeManager_001 OK
* GameModeAdventure_001 OK
* AdventureModeManager_001 OKn't because weak issues
* ZeldaCollisionBinary OK
* UnkStruct_027e09c0_001 OK
* UnkStruct_ov000_020b504c_001 OK
* UnkStruct_ov000_02067bc4.hpp -> UnkStruct_ov000_020b504c.hpp
* match overlay 97
* match overlay 100
* run ninja format
* UnkStruct_027e0ce0_30_001 OK
* UnkStruct_027e0ce0_40_Base_001 OK
* item manager files stuff
* ItemManager_001 OK
* other file things
* forgot to delete a file
* UnkStruct_027e0ce0_001 53%
* UnkStruct_027e0ce0_001 OK
* feat: begin decompiling mlck actor
* feat: improvements
* feat: save changes as a commit not as a stash eheh
* feat: improvements
* feat: better match for constructor
* style: remove dead code
* refactor: switch to fields to bool and use != 0 for unk32
* feat: Match ActorUnkRBLS vfunc_18, 20, 24 and 2C
* fix: Use FLOAT_TO_FX32 instead of raw hex
* feat: Update symbols
* fix: Fix ModelRender::vfunc_18 symbol and childs declarations
* UnkStruct_027e095c_001 OK
* UnkStruct_027e095c_001 OK (JP)
* SysNew_001 OK
* SaveManager_001 98%
* UnkStruct_027e09bc_001 OK
* MapObjectManager_001 OK
* ActorManager_001 OK
* remove useless thumb pragmas
* ItemManager_001 OK
* fix regressions
* fix build issues
* feat: begin decompiling ActorItemBoomerang
* feat: decompile functions
* refactor: rename function and use ActorState
* feat: match vfunc
* feat: magic stuff on addresses to match .data
* feat: more black magic
* feat: improvements
* feat: match .data
* feat: unmatch .data 😭
* feat: match stuff
* refactor: move shotarrows' class used in boomerang
* feat: fix mangled names
* feat: weird magic
* fix: build issues
* fix: build issue for jp version
* fix: back to +0.2% :yeah:
* feat: improvements before changing laptop
* feat: continue decompiling
* fix: build issues
* feat: improvements
* feat: solve build on eur
* fix: build issue
* fix: better match
* fix: match back ActorShotArrow data
* feat: increase .text matching
* fix: propagate changes to ActorShotArrow
* feat: matching func_ov031_020e5034
* fix: logical errors
* fix: replace whiles with fors
* style: use uppercased hex value
Co-authored-by: Yanis <35189056+Yanis002@users.noreply.github.com>
* style: do not use fx32 for global timer
Co-authored-by: Yanis <35189056+Yanis002@users.noreply.github.com>
* style: add parameters name in prototypes
Co-authored-by: Yanis <35189056+Yanis002@users.noreply.github.com>
* style: use bool instead of unk32 for external function
Co-authored-by: Yanis <35189056+Yanis002@users.noreply.github.com>
* style: use DEG2ANG
* refactor: use ActorRef instead of u16
* style: use boring array access instead of chad pointer manipulation
* fix: use bool as return type for ActorItemBoomerang::vfunc_2C
* feat: remove old non-matching comments
* style: explicit null check
* revert: change vfunc_2C back to void signature and change 01fff5d0 function's signature to bool
---------
Co-authored-by: Yanis <35189056+Yanis002@users.noreply.github.com>
* Decompile func_ov063_0215c250 and func_ov063_0215c290
* Decompile ActorUnkRMSF::~ActorUnkRMSF
Unsure what the added ldr/str instructions are
* Update func_ov063_0215c250 and func_ov063_0215c290 with right classes
* chore: Tidy up code using the right functions
* feat: Duplicate code for jp version
* feat: Add placeholder parent class to match dtors
* fix: Update the handling of jp version
* fix: Remove dup code and rename symbols
* fix: Rename vfuncs
* feat: Rename more symbols and add member to match class size
* chore: Remove autogen comments at the top of files
* feat: Fix reloc and unify used functions with RMSD
* fix: Rename vfuncs to the right id
* feat: Unify code structure to fit other RMSX files
fix: Change type of ActorUnkRMSD.mUnk_158 that was too big to unk32 as placeholder
* feat: Apply patch from Yanis
Co-authored-by: Yanis <35189056+Yanis002@users.noreply.github.com>
* fix: Update code to get rid of GetResource and use new function
* Update src/063_Shrine/Actor/ActorUnkRMSD.cpp
Co-authored-by: Yanis <35189056+Yanis002@users.noreply.github.com>
* Merge branch 'main' into ActorUnkRMSD
* fix: Format file
* feat: Rename RMSX base class
---------
Co-authored-by: Yanis <35189056+Yanis002@users.noreply.github.com>
* UnkStruct_027e09b8_001 OK
* match func_ov001_020b7830
* fix build issues
* UnkStruct_027e0cd8_001 49%
* UnkStruct_027e0cd8_001 OK
* fix build issues
* UnkStruct_027e0cd8_0C_001 92%
* port some MSL C++ headers from rb3 and key decomps
* fix build issues
* UnkStruct_027e0cd8_0C_001 98%
* feat: match ActorProfileUnkFlen and ctor of ActorUnkFlen
* feat: add function
* feat: decompile function
* feat: decompile function @ 020f8118
* feat: use break in each case
* feat: almost fully decompiled actor
* style: move external variable to top file
* feat: update symbols
* feat: better match
* refactor: rename function and use ActorState over ActorUnkFLENState
* style: cleanup code
* review
---------
Co-authored-by: Yanis002 <35189056+Yanis002@users.noreply.github.com>
* refactor: unknown arow actor to arrow
* refactor: rename ActorUnkArow_c4 and remove warning
* refactor: rename class in system files
* feat: match actorprofilearrow
* feat: progress decompilation
* feat: rename actor to ActorShotArrow
* feat: change mangled name
* feat: decompile some functions and mark unmatched functions as non-matching
* feat: progress
* feat: decompiling function 020f206c
* feat: change two fields for struct padding
* feat: remove non-matching comment on matched function
* feat: decompiling function 020f20bc
* refactor: fix .bss mangled names
* feat: decompiling 020f2134
* feat: decompiling func_ov031_020f2160
* feat: matching function func_ov031_020f21dc
* feat: use correct mangled names in jp version
* fix: change back arm9/delinks in eur version
* feat: non-matching function 020f1a64
* feat: decompile 020f2270
* feat: decompile function 020f2280
* feat: uncompile func_ov031_020f229c
* feat: match 020f22d4 add UnkSystem{4,5} as fields
* feat: reverse 020f2b8c
* feat: 020f2bbc
* feat: 020f2bec
* feat: 020f3304
* style: explicitly indicate floating values when using FLOAT_TO_Q20
* style: move external function to the top
* feat: begin of 020f3258
* feat: decompile 020f32c4
* feat: propagate mangled names changes to japan version
* feat: begin decompilation of func_ov031_020f370c
* feat: begin weird decompilation of func_ov031_020f3d4c
* feat: decompile function 020f3d04
* feat: better matching
* feat: matching function func_ov031_020f2214
* feat: decompile the function 020f3258
* feat: increase matched code
* feat: decompile function func_ov031_020f2794
* feat: decompile function func_ov031_020f18bc
* feat: decompile almost all func_ov031_020f195c
* feat: decompile 3/4 of func_ov031_020f173c
* refactor: change back function's return type to void
* feat: begin decompilation of func_ov031_020f1b04
* feat: advance decompilation of 020f1c7c
* feat: decompile 020f1e3c
* feat: decompile function func_ov031_020f1f54
* refactor: move func(Actor *) into ActorShotArrow class
* feat: introduce ActorShotArrow_194 thanks to Yanis002
* fix: use FX32 in macros over old Q20
* fix: praying magic behaviour
* revert: revert before build failure
* revert: remove all relocs.txt magic stuff
* revert: introduce back correct symbols
* revert: introduce back CORRECTLY correct symbols
* feat: rename vtable
* fix: wrong hex in comment
* feat: huge improvements
* fix: undefined 02081d7c
* fix: awful symbol name
* fix: part of mangled name in jp version
* fix: rest of the line disappeared
* fix: try to fix jp version
* fix: apply eur fix to jp
* feat: add function 020f374c
* fix: full match of 020f173c
* feat: move function in upperclass
* feat: change ActorRupee to use class function
* feat: try decompiling func_ov031_020f2ef0
* feat: improvements
* feat: improvements
* docs: add comment
* fix: build issues
* feat: improvements
* feat: improvements
* feat: forget inclusion of unkstruct
* feat: enhanced
* feat: some improvements
* style: better style
* feat: decompile function and cleanup
* refactor: remove .cache ??
* review
---------
Co-authored-by: Yanis002 <35189056+Yanis002@users.noreply.github.com>
* gcc fixes
* document random things in UnkStruct_027e09b8_00
* match func_ov001_020ba670 and rabbit docs
* match func_ov026_0211f394
* fix build issues
* match func_ov026_0211e3e0
* match func_ov026_02102924
* move structs to header
* document train rope thing
* MapObject OK and ActorRef stuff
* match more actor funcs
* fix regressions
* fix build issues
* more regressions fixes
* name keyt grab func
* UnkSubStruct19 -> CellAnimObject (based on the only assert string)
* fix build issues due to merge
* Actor::mUnk_4C -> Actor::mState + related changes
* create GetActorPtr template inline for Actor_c4
* ActorUnk_ov000_020a8bb0 -> Actor_Derived1
* actor: add comments about mUnk_50/52 and change type of mAngle
* name func_01ffd3d8 and func_01ffd400
* name func_01ffd3b0
* match func_ov024_020cf9d4 + improve the Random struct
* UnkStruct_027e0cf8_00_0C_024 45%
* match PassengerManager::GetRandomIndex
* UnkStruct_027e0cf8_00_0C_024 OK
* UnkStruct_027e0cf8_00_0C_024: do other sections
* UnkStruct_027e0cf8_08_024 55%
* cleanup: remplace delete into null by the delete macro
* UnkStruct_027e0cf8_08_024 OK
* fix build issues
* UnkStruct_ov024_020d86a0_024 OK
* PlayerActor_A0_38_024 .text OK, CreditsEndingType OK
* tools: create courselist.py to convert .CLB data to yaml
* UnkDataStruct4_14 OK
* UnkDataStruct4 17%
* UnkDataStruct4 OK
* MiscAdvManager OK
* PassengerManager OK
* fix build issues
* ZeldaTrainBinary OK
* mark PassengerManager as complete and adjust delinks
* UnkStruct_027e0cf8_08_00_024 OK
* document more of UnkStruct_027e0ce0
* savefile hotfixes
* UnkStruct_027e0ce0_34_024 OK
* code_020d46b4_024 OK
* UnkStruct_027e0d00 & UnkStruct_027e0d00_20 OK
* code_020d51dc_024 OK
* fix weird formatting
* UnkTrainSystem1 OK
* fix jp broken match
* UnkTrainSystem2 OK
* UnkStruct_027e0d08_024 31%
* fix build issues
* UnkStruct_027e0d08 OK!!!
* remove useless parenthesis
* ActorUnk_ov000_020a8bb0_EC OK
* move ActorUnk_ov000_020a8bb0_EC to MainGame/Actor/
* ActorUnkOBPC OK
* add sjiswrap support
* solve remaining gaps and fix build issues
* reorganise files + counter docs
* tools: remove format command execution from defaults
* refactor: change Q20 in macros to FX32
* fix: renaming macros does not renamed every occurrence
* fix: opaque IDE magic occurred
* refactor: revert order of libs
* refactor: remove unused macros for FX31(Q19) and FX33(Q21)
* feat: change symbols for ActorHeart
* feat: begin ActorHeart decompilation
* feat: continue decompilation (some changes should be refactored)
* improvements
* fix build issues
* feat: improve matching code
* fix: remove back nitro/math
* feat: load s8 as u8
* refactor: remove shady variadic function
* feat: better function, reg order issue
* refactor: switch EC, F0 and F4 to a single VecFx32 variable and improve vfunc_20
* feat: improvements in vfunc_v20
* docs: add what should be written in comments
* feat: match with temporary unknown actor structure
* style: remove unnecessary curly brackets in switch cases
* style: move external functions to the top
* docs: mark unmatched functions as non-matching
* refactor: use FLOAT_TO_Q20 instead of raw hex values
* style: remove unnecessary cast
* refactor: use macros to manipulate flags
* refactor: better floating values
* refactor: use hex values over bin values
* feat: use ROUND_Q20 to increase matching
* refactor: use Cylinder::Init instead of assigning each variable
* refactor: change mangled names
---------
Co-authored-by: Yanis002 <35189056+Yanis002@users.noreply.github.com>
* merge headers from nitro decomp
* cleanup: use inlines from g2.h and gx.h when changing registers
* cleanup: remove externs declarations in source files
* GameModeAdventure_001 OK
* GameModeAdventure_024 17%
* GameModeAdventure_024 73%
* GameModeAdventure_024 99%
* jp region differences
* rename GameModeAdventure_024 and GameModeAdventure + UnkStruct_ov000_020d8660_024 OK
* UnkActorSystem1OK
* UnkActorSystem2 OK
* delink more of ov024 & UnkStruct_027e0998_024 OK
* improve instance stuff & UnkStruct_027e0cf8_024 OK
* AdventureModeManager_160_024 OK & GameModeStartUp OK
* fix regressions
* fix regressions 2
* AdventureModeManager_170 OK
* AdventureModeManager_174_Base OK
* AdventureModeManager_174 OK
* mark GameModeAdventure_024 as complete
* AdventureModeManager_178 OK
* AdventureModeManager_180 OK
* AdventureModeManager_184_024 OK
* AdventureModeManager_18C_024 OK & AdventureModeManager_190_024 OK
* AdventureModeManager_15C_20_00 61%
* AdventureModeManager_15C_20_00 OK
* jp version differences
* delink what's left in the overlay
* fix regressions
* AdventureModeManager_1B8_Base_024 98%
* AdventureModeManager_1B8 48% and link AdventureModeManager_024
* AdventureModeManager_1B8_Base and AdventureModeManager_1B8 OK
* oops
* mark statics as local
* name item 31 to 34
* name item 25 to 29
* decompile PassengerManager (95%)
* started cargo manager
* local attribute
* passenger/cargo manager ov001 functions
* name item manager functions
* fix build issues & more docs on 027e0cd8
* format
* playrget progress and match treasuremanager remaining functions
* some docs
* fix build issues
* random docs
* match func_ov094_02172290
* random docs
* actor cleanup
* match freestanding item funcs
* mType -> mpProfile
* decompile random functions
* docs and start of wip chest stuff
* random docs
* more random docs
* match func_ov036_0211d0a8
* match func_ov036_0211d2dc & func_ov036_0211d570
* match func_ov110_02184a40
* random doc
* document letter/stamps system
* match func_ov001_020bb9f8
* fix build issues
* decompile tres
* start decomp chest base
* fix regressions
* name TRES
* name UnkStruct_ov024_020d86b0
* name stamp types and update save struct stuff
* name things and document BMG IDs
Mityno